May 14, 2025 · Apr 25, 2025 · Apr 25, 2025 · Apr 25, 2025 · Apr 25, 2025 · Apr 25, 2025
diff --git a/coderd/provisionerdserver/provisionerdserver_test.go b/coderd/provisionerdserver/provisionerdserver_test.go
 "github.com/coder/coder/v2/coderd/telemetry"
 "github.com/coder/coder/v2/coderd/wspubsub"
 "github.com/coder/coder/v2/codersdk"
 "github.com/coder/coder/v2/codersdk/agentsdk"
 "github.com/coder/coder/v2/provisionerd/proto"
 "github.com/coder/coder/v2/provisionersdk"
 sdkproto "github.com/coder/coder/v2/provisionersdk/proto"

 // GIVEN something is listening to process workspace reinitialization:
 reinitChan := make(chan agentsdk.ReinitializationEvent, 1) // Buffered to simplify test structure
 cancel, err :=prebuilds.NewPubsubWorkspaceClaimListener(ps, testutil.Logger(t)).ListenForWorkspaceClaims(ctx, workspace.ID, reinitChan)
 cancel, err :=agplprebuilds.NewPubsubWorkspaceClaimListener(ps, testutil.Logger(t)).ListenForWorkspaceClaims(ctx, workspace.ID, reinitChan)
 require.NoError(t, err)
 defer cancel()

diff --git a/provisioner/terraform/executor.go b/provisioner/terraform/executor.go
 return filtered
 }

 func (e *executor) logResourceReplacements(ctx context.Context, plan *tfjson.Plan) {
 if plan == nil {
 return
 }

 if len(plan.ResourceChanges) == 0 {
 return
 }
 var (
 count        int
 replacements = make(map[string][]string, len(plan.ResourceChanges))
 )

 for _, ch := range plan.ResourceChanges {
 // No change, no problem!
 if ch.Change == nil {
 continue
 }

 // No-op change, no problem!
 if ch.Change.Actions.NoOp() {
 continue
 }

 // No replacements, no problem!
 if len(ch.Change.ReplacePaths) == 0 {
 continue
 }

 // Replacing our resources, no problem!
 if strings.Index(ch.Type, "coder_") == 0 {
 continue
 }

 for _, p := range ch.Change.ReplacePaths {
 var path string
 switch p := p.(type) {
 case []interface{}:
 segs := p
 list := make([]string, 0, len(segs))
 for _, s := range segs {
 list = append(list, fmt.Sprintf("%v", s))
 }
 path = strings.Join(list, ".")
 default:
 path = fmt.Sprintf("%v", p)
 }

 replacements[ch.Address] = append(replacements[ch.Address], path)
 }

 count++
 }

 if count > 0 {
 e.server.logger.Warn(ctx, "plan introduces resource changes", slog.F("count", count))
 for n, p := range replacements {
 e.server.logger.Warn(ctx, "resource will be replaced", slog.F("name", n), slog.F("replacement_paths", strings.Join(p, ",")))
 }
 }
 }

 // planResources must only be called while the lock is held.
 func (e *executor) planResources(ctx, killCtx context.Context, planfilePath string) (*State, *tfjson.Plan, error) {
 ctx, span := e.server.startTrace(ctx, tracing.FuncName())
 return nil, nil, xerrors.Errorf("show terraform plan file: %w", err)
 }

 e.logResourceReplacements(ctx, plan)

 rawGraph, err := e.graph(ctx, killCtx)
 if err != nil {
 return nil, nil, xerrors.Errorf("graph: %w", err)
Original file line number	Diff line number	Diff line change
Expand Up		@@ -45,6 +45,7 @@ import (
		"github.com/coder/coder/v2/coderd/telemetry"
		"github.com/coder/coder/v2/coderd/wspubsub"
		"github.com/coder/coder/v2/codersdk"
		"github.com/coder/coder/v2/codersdk/agentsdk"
		"github.com/coder/coder/v2/provisionerd/proto"
		"github.com/coder/coder/v2/provisionersdk"
		sdkproto "github.com/coder/coder/v2/provisionersdk/proto"
Expand DownExpand Up		@@ -1887,7 +1888,7 @@ func TestCompleteJob(t *testing.T) {

		// GIVEN something is listening to process workspace reinitialization:
		reinitChan := make(chan agentsdk.ReinitializationEvent, 1) // Buffered to simplify test structure
		cancel, err :=prebuilds.NewPubsubWorkspaceClaimListener(ps, testutil.Logger(t)).ListenForWorkspaceClaims(ctx, workspace.ID, reinitChan)
		cancel, err :=agplprebuilds.NewPubsubWorkspaceClaimListener(ps, testutil.Logger(t)).ListenForWorkspaceClaims(ctx, workspace.ID, reinitChan)
		require.NoError(t, err)
		defer cancel()

Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -382,68 +382,6 @@ func onlyDataResources(sm tfjson.StateModule) tfjson.StateModule {
		return filtered
		}

		func (e executor) logResourceReplacements(ctx context.Context, plan tfjson.Plan) {
		if plan == nil {
		return
		}

		if len(plan.ResourceChanges) == 0 {
		return
		}
		var (
		count int
		replacements = make(map[string][]string, len(plan.ResourceChanges))
		)

		for _, ch := range plan.ResourceChanges {
		// No change, no problem!
		if ch.Change == nil {
		continue
		}

		// No-op change, no problem!
		if ch.Change.Actions.NoOp() {
		continue
		}

		// No replacements, no problem!
		if len(ch.Change.ReplacePaths) == 0 {
		continue
		}

		// Replacing our resources, no problem!
		if strings.Index(ch.Type, "coder_") == 0 {
		continue
		}

		for _, p := range ch.Change.ReplacePaths {
		var path string
		switch p := p.(type) {
		case []interface{}:
		segs := p
		list := make([]string, 0, len(segs))
		for _, s := range segs {
		list = append(list, fmt.Sprintf("%v", s))
		}
		path = strings.Join(list, ".")
		default:
		path = fmt.Sprintf("%v", p)
		}

		replacements[ch.Address] = append(replacements[ch.Address], path)
		}

		count++
		}

		if count > 0 {
		e.server.logger.Warn(ctx, "plan introduces resource changes", slog.F("count", count))
		for n, p := range replacements {
		e.server.logger.Warn(ctx, "resource will be replaced", slog.F("name", n), slog.F("replacement_paths", strings.Join(p, ",")))
		}
		}
		}

		// planResources must only be called while the lock is held.
		func (e executor) planResources(ctx, killCtx context.Context, planfilePath string) (State, *tfjson.Plan, error) {
		ctx, span := e.server.startTrace(ctx, tracing.FuncName())
Expand All		@@ -454,8 +392,6 @@ func (e *executor) planResources(ctx, killCtx context.Context, planfilePath stri
		return nil, nil, xerrors.Errorf("show terraform plan file: %w", err)
		}

		e.logResourceReplacements(ctx, plan)

		rawGraph, err := e.graph(ctx, killCtx)
		if err != nil {
		return nil, nil, xerrors.Errorf("graph: %w", err)
Expand Down