Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: display validation error for workspace name#17564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 3 commits intomainfromjaaydenh/workspace-name-validation
Apr 30, 2025
Merged
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,6 +28,7 @@ import {
useContext,
useEffect,
useId,
useRef,
useState,
} from "react";
import { getFormHelpers, nameValidator } from "utils/formUtils";
Expand DownExpand Up@@ -103,6 +104,7 @@ export const CreateWorkspacePageViewExperimental: FC<
);
const [showPresetParameters, setShowPresetParameters] = useState(false);
const id = useId();
const workspaceNameInputRef = useRef<HTMLInputElement>(null);
const rerollSuggestedName = useCallback(() => {
setSuggestedName(() => generateWorkspaceName());
}, []);
Expand DownExpand Up@@ -140,10 +142,15 @@ export const CreateWorkspacePageViewExperimental: FC<
}
}, [error]);

const getFieldHelpers = getFormHelpers<TypesGen.CreateWorkspaceRequest>(
form,
error,
);
useEffect(() => {
if (form.submitCount > 0 && form.errors) {
workspaceNameInputRef.current?.scrollIntoView({
behavior: "smooth",
block: "center",
});
workspaceNameInputRef.current?.focus();
}
}, [form.submitCount, form.errors]);

const [presetOptions, setPresetOptions] = useState([
{ label: "None", value: "" },
Expand DownExpand Up@@ -333,16 +340,22 @@ export const CreateWorkspacePageViewExperimental: FC<
<Label className="text-sm" htmlFor={`${id}-workspace-name`}>
Workspace name
</Label>
<div>
<div className="flex flex-col">
<Input
id={`${id}-workspace-name`}
ref={workspaceNameInputRef}
value={form.values.name}
onChange={(e) => {
form.setFieldValue("name", e.target.value.trim());
resetMutation();
}}
disabled={creatingWorkspace}
/>
{form.touched.name && form.errors.name && (
<div className="text-content-destructive text-xs mt-2">
{form.errors.name}
</div>
)}
<div className="flex gap-2 text-xs text-content-secondary items-center">
Need a suggestion?
<Button
Expand DownExpand Up@@ -477,7 +490,6 @@ export const CreateWorkspacePageViewExperimental: FC<

return (
<DynamicParameter
{...getFieldHelpers(parameterInputName)}
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since we are not using the MUI TextField, this is not necessary

key={parameter.name}
parameter={parameter}
onChange={(value) =>
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp