Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: display validation error for workspace name#17564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 3 commits intomainfromjaaydenh/workspace-name-validation
Apr 30, 2025

Conversation

jaaydenh
Copy link
Contributor

  • Display form validation error for workspace name
  • Scroll to the workspace name field if there is a validation error

@jaaydenhjaaydenh self-assigned thisApr 24, 2025
@@ -477,7 +488,6 @@ export const CreateWorkspacePageViewExperimental: FC<

return (
<DynamicParameter
{...getFieldHelpers(parameterInputName)}
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Since we are not using the MUI TextField, this is not necessary

@jaaydenhjaaydenh requested a review fromaslilacApril 24, 2025 17:45
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

you need to use aref here

jaaydenh reacted with thumbs up emoji
@jaaydenh
Copy link
ContributorAuthor

@aslilac updated for useRef

@jaaydenhjaaydenh requested a review fromaslilacApril 30, 2025 11:49
@jaaydenhjaaydenhforce-pushed thejaaydenh/workspace-name-validation branch frombb92ca8 todd76a3aCompareApril 30, 2025 16:02
@jaaydenhjaaydenh merged commitd104cd6 intomainApr 30, 2025
29 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/workspace-name-validation branchApril 30, 2025 20:45
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 30, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jaaydenh@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp