NotificationsYou must be signed in to change notification settings
Fork1k
Star11.2k

chore: mark parameters as required#17551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jaaydenh merged 2 commits intomainfromjaaydenh/dynamic-params-required-fields

Apr 24, 2025

Merged

chore: mark parameters as required#17551

jaaydenh merged 2 commits intomainfromjaaydenh/dynamic-params-required-fields

Apr 24, 2025

Conversation

Copy link

Contributor

jaaydenh commentedApr 23, 2025•
edited
Loading

This adds a red asterisk next to a parameter name if it is required and marks passes the parameter required value to input and textarea form controls.

The multi-select combobox needs additional work (in a separate PR) so that it can handle the required prop correctly for form submit.

chore: mark parameters as required

644795c

jaaydenh self-assigned this

Apr 23, 2025

jaaydenh commented

Apr 23, 2025

View reviewed changes

site/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx

		<LabelclassName="flex gap-2 flex-wrap text-sm font-medium">
		{displayName}

		<spanclassName="flex">

Copy link

ContributorAuthor

jaaydenhApr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

For now, I decided to add the required asterisk for all parameters even though it really doesn't make sense for (checkbox, slider, radio, switch) since all parameters have the required prop.