- Notifications
You must be signed in to change notification settings - Fork907
fix: add websocket close handling#17548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -107,6 +108,15 @@ const CreateWorkspacePageExperimental: FC = () => { | |||
| onError: (error) => { | |||
| setWsError(error); | |||
| }, | |||
| onClose: () => { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The assumption is that if the websocket closes while the component is mounted, that this is unexpected and we should inform the user with an error in the UI
site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
ef6e6e4 intomainUh oh!
There was an error while loading.Please reload this page.
resolves#17508
Display an error in the UI that the websocket closed if the user is still interacting with the dynamic parameters form