Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add prebuilds metrics collector#17547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
dannykopping merged 6 commits intomainfromdk/prebuilds-metrics
Apr 28, 2025
Merged

Conversation

dannykopping
Copy link
Contributor

@dannykoppingdannykopping commentedApr 23, 2025•
edited
Loading

Copy link
Contributor

@SasSwartSasSwart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just pointing out a TODO that we still need to look into. Otherwise, looks good.

Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

A few small suggestions/nits, otherwise LGTM

@dannykoppingdannykoppingforce-pushed thedk/prebuilds-metrics branch 2 times, most recently froma69ee41 to7791f50CompareApril 25, 2025 07:51
Base automatically changed fromdk/enable-prebuilds tomainApril 25, 2025 09:07
Signed-off-by: Danny Kopping <dannykopping@gmail.com>Reverting unnecessary changes that crept inSigned-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
@dannykoppingdannykopping marked this pull request as ready for reviewApril 25, 2025 09:14
Copy link
Member

@mafredrimafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One minor nit/observation, otherwise LGTM!

{"coderd_prebuilt_workspaces_eligible", ptr.To(0.0), false},
},
templateDeleted: []bool{false},
eligible: []bool{false},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not seeing any test-cases where we'd need slices for deleted/eligible and it probably isn't too compatible with the way expected metrics are defined. Consider simplifying (helps reduce complexity of test body too)?

@dannykoppingdannykopping merged commite0483e3 intomainApr 28, 2025
31 checks passed
@dannykoppingdannykopping deleted the dk/prebuilds-metrics branchApril 28, 2025 10:29
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@SasSwartSasSwartSasSwart left review comments

@mafredrimafredrimafredri approved these changes

Assignees

@dannykoppingdannykopping

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prebuilds Metrics
3 participants
@dannykopping@mafredri@SasSwart
[8]ページ先頭
©2009-2025 Movatter.jp