Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore(dogfood): increase container graceful stop time#17528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedApr 23, 2025•
edited
Loading

Fixes workspace stop when you've rundevcontainer up in coder/coder.

The previous attempt in#17110 gave insufficient time.

@matifali
Copy link
Member

If this works out, we should make the same changes to our sample Docker templates.

@mafredrimafredri merged commit1ba02f4 intomainApr 23, 2025
32 checks passed
@mafredrimafredri deleted the mafredri/chore-increase-contrainer-graceful-stop-time-in-df branchApril 23, 2025 10:40
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 23, 2025
@mafredri
Copy link
MemberAuthor

If this works out, we should make the same changes to our sample Docker templates.

@matifali It should, I've tested it onhttps://dev.coder.com/templates/coder/maf-devcontainers and works as expected. I haven't tested when stop is initiated via autostop, but I expect it to work as well.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mafredri@matifali
[8]ページ先頭
©2009-2025 Movatter.jp