Apr 23, 2025 · Apr 22, 2025 · Apr 23, 2025
diff --git a/coderd/apidoc/docs.go b/coderd/apidoc/docs.go
diff --git a/coderd/apidoc/swagger.json b/coderd/apidoc/swagger.json
diff --git a/coderd/workspaces.go b/coderd/workspaces.go
 if req.TemplateVersionID != uuid.Nil {
 builder = builder.VersionID(req.TemplateVersionID)
 }
 if req.EnableDynamicParameters && api.Experiments.Enabled(codersdk.ExperimentDynamicParameters) {
 builder = builder.UsingDynamicParameters()
 }

 workspaceBuild, provisionerJob, provisionerDaemons, err = builder.Build(
 ctx,
diff --git a/coderd/wsbuilder/wsbuilder.go b/coderd/wsbuilder/wsbuilder.go
 logLevel         string
 deploymentValues *codersdk.DeploymentValues

 richParameterValues     []codersdk.WorkspaceBuildParameter
 initiator               uuid.UUID
 reason                  database.BuildReason
 templateVersionPresetID uuid.UUID
 richParameterValues      []codersdk.WorkspaceBuildParameter
 dynamicParametersEnabled bool
 initiator                uuid.UUID
 reason                   database.BuildReason
 templateVersionPresetID  uuid.UUID

 // used during build, makes function arguments less verbose
 ctx   context.Context
 return b
 }

 func (b Builder) UsingDynamicParameters() Builder {
 b.dynamicParametersEnabled = true
 return b
 }

 // SetLastWorkspaceBuildInTx prepopulates the Builder's cache with the last workspace build.  This allows us
 // to avoid a repeated database query when the Builder's caller also needs the workspace build, e.g. auto-start &
 // auto-stop.
 if err != nil {
 return nil, nil, BuildError{http.StatusBadRequest, "Unable to build workspace with unsupported parameters", err}
 }

 resolver := codersdk.ParameterResolver{
 Rich: db2sdk.WorkspaceBuildParameters(lastBuildParameters),
 }
 if err != nil {
 return nil, nil, BuildError{http.StatusInternalServerError, "failed to convert template version parameter", err}
 }
 value, err := resolver.ValidateResolve(
 tvp,
 b.findNewBuildParameterValue(templateVersionParameter.Name),
 )
 if err != nil {
 // At this point, we've queried all the data we need from the database,
 // so the only errors are problems with the request (missing data, failed
 // validation, immutable parameters, etc.)
 return nil, nil, BuildError{http.StatusBadRequest, fmt.Sprintf("Unable to validate parameter %q", templateVersionParameter.Name), err}

 var value string
 if !b.dynamicParametersEnabled {
 var err error
 value, err = resolver.ValidateResolve(
 tvp,
 b.findNewBuildParameterValue(templateVersionParameter.Name),
 )
 if err != nil {
 // At this point, we've queried all the data we need from the database,
 // so the only errors are problems with the request (missing data, failed
 // validation, immutable parameters, etc.)
 return nil, nil, BuildError{http.StatusBadRequest, fmt.Sprintf("Unable to validate parameter %q", templateVersionParameter.Name), err}
 }
 } else {
 value = resolver.Resolve(tvp, b.findNewBuildParameterValue(templateVersionParameter.Name))
 }

 names = append(names, templateVersionParameter.Name)
 values = append(values, value)
 }
diff --git a/codersdk/organizations.go b/codersdk/organizations.go
 RichParameterValues     []WorkspaceBuildParameter `json:"rich_parameter_values,omitempty"`
 AutomaticUpdates        AutomaticUpdates          `json:"automatic_updates,omitempty"`
 TemplateVersionPresetID uuid.UUID                 `json:"template_version_preset_id,omitempty" format:"uuid"`
 EnableDynamicParameters bool                      `json:"enable_dynamic_parameters,omitempty"`
 }

 func (c *Client) OrganizationByName(ctx context.Context, name string) (Organization, error) {
diff --git a/codersdk/richparameters.go b/codersdk/richparameters.go
 return resolvedValue.Value, nil
 }

 // Resolve returns the value of the parameter. It does not do any validation,
 // and is meant for use with the new dynamic parameters code path.
 func (r *ParameterResolver) Resolve(p TemplateVersionParameter, v *WorkspaceBuildParameter) string {
 prevV := r.findLastValue(p)
 // First, the provided value
 resolvedValue := v
 // Second, previous value if not ephemeral
 if resolvedValue == nil && !p.Ephemeral {
 resolvedValue = prevV
 }
 // Last, default value
 if resolvedValue == nil {
 resolvedValue = &WorkspaceBuildParameter{
 Name:  p.Name,
 Value: p.DefaultValue,
 }
 }
 return resolvedValue.Value
 }

 // findLastValue finds the value from the previous build and returns it, or nil if the parameter had no value in the
 // last build.
 func (r *ParameterResolver) findLastValue(p TemplateVersionParameter) *WorkspaceBuildParameter {
diff --git a/docs/reference/api/schemas.md b/docs/reference/api/schemas.md
diff --git a/docs/reference/api/workspaces.md b/docs/reference/api/workspaces.md
diff --git a/site/src/api/typesGenerated.ts b/site/src/api/typesGenerated.ts
diff --git a/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx b/site/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx

 const workspace = await createWorkspaceMutation.mutateAsync({
 ...workspaceRequest,
 enable_dynamic_parameters: true,
 userId: owner.id,
 });
 onCreateWorkspace(workspace);
Original file line number	Diff line number	Diff line change
Expand Up		@@ -676,6 +676,9 @@ func createWorkspace(
		if req.TemplateVersionID != uuid.Nil {
		builder = builder.VersionID(req.TemplateVersionID)
		}
		if req.EnableDynamicParameters && api.Experiments.Enabled(codersdk.ExperimentDynamicParameters) {
aslilac marked this conversation as resolved. Show resolvedHide resolved
		builder = builder.UsingDynamicParameters()
		}

		workspaceBuild, provisionerJob, provisionerDaemons, err = builder.Build(
		ctx,
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -51,10 +51,11 @@ type Builder struct {
		logLevel string
		deploymentValues *codersdk.DeploymentValues

		richParameterValues []codersdk.WorkspaceBuildParameter
		initiator uuid.UUID
		reason database.BuildReason
		templateVersionPresetID uuid.UUID
		richParameterValues []codersdk.WorkspaceBuildParameter
		dynamicParametersEnabled bool
		initiator uuid.UUID
		reason database.BuildReason
		templateVersionPresetID uuid.UUID

		// used during build, makes function arguments less verbose
		ctx context.Context
Expand DownExpand Up		@@ -178,6 +179,11 @@ func (b Builder) MarkPrebuild() Builder {
		return b
		}

		func (b Builder) UsingDynamicParameters() Builder {
		b.dynamicParametersEnabled = true
		return b
		}

		// SetLastWorkspaceBuildInTx prepopulates the Builder's cache with the last workspace build. This allows us
		// to avoid a repeated database query when the Builder's caller also needs the workspace build, e.g. auto-start &
		// auto-stop.
Expand DownExpand Up		@@ -578,6 +584,7 @@ func (b *Builder) getParameters() (names, values []string, err error) {
		if err != nil {
		return nil, nil, BuildError{http.StatusBadRequest, "Unable to build workspace with unsupported parameters", err}
		}

		resolver := codersdk.ParameterResolver{
		Rich: db2sdk.WorkspaceBuildParameters(lastBuildParameters),
		}
Expand All		@@ -586,16 +593,24 @@ func (b *Builder) getParameters() (names, values []string, err error) {
		if err != nil {
		return nil, nil, BuildError{http.StatusInternalServerError, "failed to convert template version parameter", err}
		}
		value, err := resolver.ValidateResolve(
		tvp,
		b.findNewBuildParameterValue(templateVersionParameter.Name),
		)
		if err != nil {
		// At this point, we've queried all the data we need from the database,
		// so the only errors are problems with the request (missing data, failed
		// validation, immutable parameters, etc.)
		return nil, nil, BuildError{http.StatusBadRequest, fmt.Sprintf("Unable to validate parameter %q", templateVersionParameter.Name), err}

		var value string
		if !b.dynamicParametersEnabled {
		var err error
		value, err = resolver.ValidateResolve(
		tvp,
		b.findNewBuildParameterValue(templateVersionParameter.Name),
		)
		if err != nil {
		// At this point, we've queried all the data we need from the database,
		// so the only errors are problems with the request (missing data, failed
		// validation, immutable parameters, etc.)
		return nil, nil, BuildError{http.StatusBadRequest, fmt.Sprintf("Unable to validate parameter %q", templateVersionParameter.Name), err}
		}
		} else {
		value = resolver.Resolve(tvp, b.findNewBuildParameterValue(templateVersionParameter.Name))
		}

		names = append(names, templateVersionParameter.Name)
		values = append(values, value)
		}
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -227,6 +227,7 @@ type CreateWorkspaceRequest struct {
		RichParameterValues []WorkspaceBuildParameter `json:"rich_parameter_values,omitempty"`
		AutomaticUpdates AutomaticUpdates `json:"automatic_updates,omitempty"`
		TemplateVersionPresetID uuid.UUID `json:"template_version_preset_id,omitempty" format:"uuid"`
		EnableDynamicParameters bool `json:"enable_dynamic_parameters,omitempty"`
		}

		func (c *Client) OrganizationByName(ctx context.Context, name string) (Organization, error) {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -190,6 +190,26 @@ func (r ParameterResolver) ValidateResolve(p TemplateVersionParameter, v Works
		return resolvedValue.Value, nil
		}

		// Resolve returns the value of the parameter. It does not do any validation,
		// and is meant for use with the new dynamic parameters code path.
		func (r ParameterResolver) Resolve(p TemplateVersionParameter, v WorkspaceBuildParameter) string {
		prevV := r.findLastValue(p)
		// First, the provided value
		resolvedValue := v
		// Second, previous value if not ephemeral
		if resolvedValue == nil && !p.Ephemeral {
		resolvedValue = prevV
		}
		// Last, default value
		if resolvedValue == nil {
		resolvedValue = &WorkspaceBuildParameter{
		Name: p.Name,
		Value: p.DefaultValue,
		}
		}
		return resolvedValue.Value
		}

		// findLastValue finds the value from the previous build and returns it, or nil if the parameter had no value in the
		// last build.
		func (r ParameterResolver) findLastValue(p TemplateVersionParameter) WorkspaceBuildParameter {
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -282,6 +282,7 @@ const CreateWorkspacePageExperimental: FC = () => {

		const workspace = await createWorkspaceMutation.mutateAsync({
		...workspaceRequest,
		enable_dynamic_parameters: true,
		userId: owner.id,
		});
		onCreateWorkspace(workspace);
Expand Down