- Notifications
You must be signed in to change notification settings - Fork1k
chore: revert dynamic params as a safe experiment#17510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
cdr-botbot left a comment• edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR is no longer a hotfix.
- ✅ Base is main or release branch
- ❌ Has hotfix label
- ✅ Head is from coder/coder
- ✅ Less than 100 lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Safe is a much better name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Good call 👍
ca38729 intomainUh oh!
There was an error while loading.Please reload this page.
| varExperimentsAll=Experiments{ | ||
| ExperimentDynamicParameters, | ||
| } | ||
| varExperimentsSafe=Experiments{} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this is such a good and necessary rename. thank you!
No description provided.