Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add link to provisioner jobs and daemons#17509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
BrunoQuaresma merged 6 commits intomainfrombq/link-provisioners
Apr 28, 2025

Conversation

BrunoQuaresma
Copy link
Collaborator

Close#17314

Demo

Screen.Recording.2025-04-22.at.11.18.42.mov

Changes

  • Added thexs button variant
  • Display all the daemons - idle and offline - and set a size limit to 100 results (explanation in the demo)
  • Filter daemons and jobs by ID

@BrunoQuaresmaBrunoQuaresma requested a review froma teamApril 22, 2025 15:25
@BrunoQuaresmaBrunoQuaresma self-assigned thisApr 22, 2025
@BrunoQuaresmaBrunoQuaresma requested review fromaqandrew and removed request fora teamApril 22, 2025 15:25
Copy link
Contributor

@brettkolodnybrettkolodny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Mostly nits but I think there are some opportunities to clean up some unsafe code

Copy link
Contributor

@brettkolodnybrettkolodny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

lgtm!

BrunoQuaresma reacted with heart emoji
@BrunoQuaresmaBrunoQuaresma merged commit3ab3ef8 intomainApr 28, 2025
30 of 31 checks passed
@BrunoQuaresmaBrunoQuaresma deleted the bq/link-provisioners branchApril 28, 2025 14:38
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 28, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@brettkolodnybrettkolodnybrettkolodny approved these changes

@aqandrewaqandrewAwaiting requested review from aqandrewaqandrew was automatically assigned from coder/ts

Assignees

@BrunoQuaresmaBrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link provisioners and provisioner jobs in the UI
2 participants
@BrunoQuaresma@brettkolodny
[8]ページ先頭
©2009-2025 Movatter.jp