Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: update dynamic params styles#17489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 5 commits intomainfromjaaydenh/dynamic-params-style-updates
Apr 21, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedApr 21, 2025•
edited
Loading

  1. increase form width and adjust form field widthnew "create workspace" form feels too skinny #17471
  2. Move slider value display as its currently broken for long parameter titles and descriptions
  3. increase the height of the slider
  4. automatically increase the height of the textarea as the user typesparameters: auto expand textarea when typing #17472

@jaaydenhjaaydenh self-assigned thisApr 21, 2025
@jaaydenhjaaydenh requested a review fromaslilacApril 21, 2025 16:50
@jaaydenhjaaydenh changed the titlefix: dynamic params style updatesfix: update dynamic params stylesApr 21, 2025
@jaaydenhjaaydenhforce-pushed thejaaydenh/dynamic-params-style-updates branch fromcbe052e to69a9e03CompareApril 21, 2025 16:53
Comment on lines 320 to 324
onInput={(e) => {
const target = e.currentTarget;
target.style.height = "auto";
target.style.height = `${target.scrollHeight}px`;
}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

we probably need a max height to go with this

jaaydenh reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

and a max width too..

@jaaydenhjaaydenh merged commit56ee5d8 intomainApr 21, 2025
29 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/dynamic-params-style-updates branchApril 21, 2025 21:50
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@jaaydenh@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp