Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: update url for parameters websocket endpoint#17462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 1 commit intomainfromlilac/update-parameters-endpoint
Apr 17, 2025
Merged
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletionsite/src/api/api.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1010,6 +1010,7 @@ class ApiMethods {
};

templateVersionDynamicParameters = (
userId: string,
versionId: string,
{
onMessage,
Expand All@@ -1020,7 +1021,7 @@ class ApiMethods {
},
): WebSocket => {
const socket = createWebSocket(
`/api/v2/templateversions/${versionId}/dynamic-parameters`,
`/api/v2/users/${userId}/templateversions/${versionId}/parameters`,
);

socket.addEventListener("message", (event) =>
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -57,6 +57,8 @@ const CreateWorkspacePageExperimental: FC = () => {
const [mode, setMode] = useState(() => getWorkspaceMode(searchParams));
const [autoCreateError, setAutoCreateError] =
useState<ApiErrorResponse | null>(null);
const defaultOwner = me;
const [owner, setOwner] = useState(defaultOwner);

const queryClient = useQueryClient();
const autoCreateWorkspaceMutation = useMutation(
Expand DownExpand Up@@ -96,19 +98,23 @@ const CreateWorkspacePageExperimental: FC = () => {
return;
}

const socket = API.templateVersionDynamicParameters(realizedVersionId, {
onMessage,
onError: (error) => {
setWsError(error);
const socket = API.templateVersionDynamicParameters(
owner.id,
realizedVersionId,
{
onMessage,
onError: (error) => {
setWsError(error);
},
},
});
);

ws.current = socket;

return () => {
socket.close();
};
}, [realizedVersionId, onMessage]);
}, [owner.id,realizedVersionId, onMessage]);

const sendMessage = useCallback((formValues: Record<string, string>) => {
setWSResponseId((prevId) => {
Expand DownExpand Up@@ -237,7 +243,9 @@ const CreateWorkspacePageExperimental: FC = () => {
defaultName={defaultName}
diagnostics={currentResponse?.diagnostics ?? []}
disabledParams={disabledParams}
defaultOwner={me}
defaultOwner={defaultOwner}
owner={owner}
setOwner={setOwner}
autofillParameters={autofillParameters}
error={
wsError ||
Expand Down
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,14 +22,7 @@ import {
useValidationSchemaForDynamicParameters,
} from "modules/workspaces/DynamicParameter/DynamicParameter";
import { generateWorkspaceName } from "modules/workspaces/generateWorkspaceName";
import {
type FC,
useCallback,
useEffect,
useId,
useMemo,
useState,
} from "react";
import { type FC, useCallback, useEffect, useId, useState } from "react";
import { getFormHelpers, nameValidator } from "utils/formUtils";
import type { AutofillBuildParameter } from "utils/richParameters";
import * as Yup from "yup";
Expand DownExpand Up@@ -65,6 +58,8 @@ export interface CreateWorkspacePageViewExperimentalProps {
resetMutation: () => void;
sendMessage: (message: Record<string, string>) => void;
startPollingExternalAuth: () => void;
owner: TypesGen.User;
setOwner: (user: TypesGen.User) => void;
}

export const CreateWorkspacePageViewExperimental: FC<
Expand All@@ -91,8 +86,9 @@ export const CreateWorkspacePageViewExperimental: FC<
resetMutation,
sendMessage,
startPollingExternalAuth,
owner,
setOwner,
}) => {
const [owner, setOwner] = useState(defaultOwner);
const [suggestedName, setSuggestedName] = useState(() =>
generateWorkspaceName(),
);
Expand DownExpand Up@@ -140,14 +136,6 @@ export const CreateWorkspacePageViewExperimental: FC<
error,
);

const autofillByName = useMemo(
() =>
Object.fromEntries(
autofillParameters.map((param) => [param.name, param]),
),
[autofillParameters],
);

const [presetOptions, setPresetOptions] = useState([
{ label: "None", value: "" },
]);
Expand DownExpand Up@@ -252,7 +240,7 @@ export const CreateWorkspacePageViewExperimental: FC<

return (
<>
<div className="absolutesticky top-5 ml-10">
<div className="sticky top-5 ml-10">
<button
onClick={onCancel}
type="button"
Expand Down
Loading

[8]ページ先頭

©2009-2025 Movatter.jp