- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: implement claiming of prebuilt workspaces#17458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
38 commits Select commitHold shift + click to select a range
8b9e30d feat: implement claiming of prebuilt workspaces
evgeniy-scherbinad9497df Merge branch 'main' of github.com:/coder/coder into yevhenii/512-clai…
dannykopping217e46f Reverting unncessary changes
dannykoppingc459533 Refactoring
dannykoppingf905219 Removing unnecessary field
dannykopping8266338 make fmt
dannykopping4098ed7 CR's fixes
evgeniy-scherbina50d23e4 CR's fixes
evgeniy-scherbina546b7ae Update coderd/workspaces.go
evgeniy-scherbina85f7926 CR's fixes
evgeniy-scherbinaee9908c CR's fixes
evgeniy-scherbina70bf179 CR's fixes
evgeniy-scherbina7a72d03 CR's fixes
evgeniy-scherbinab246589 fix tests by updating noop.go
evgeniy-scherbinaff8d3de Merge branch 'main' of github.com:/coder/coder into yevhenii/512-clai…
dannykoppingfcdbba8 test: add failure testcase scenario
evgeniy-scherbinae7b7f80 refactor: revert interface changes
evgeniy-scherbinae7455db refactor: simplify signature of claim method
evgeniy-scherbina077d7f0 refactor: CR's fixes
evgeniy-scherbina0d426c7 Merge remote-tracking branch 'origin/main' into yevhenii/512-claim-pr…
evgeniy-scherbina663a8c0 refactor: CR's fixes
evgeniy-scherbinabc31fac refactor: make lint
evgeniy-scherbina087bd20 refactor: fix linter
evgeniy-scherbina9f66169 refactor: remove PrebuildsOrchestrator context from claim tests
evgeniy-scherbina7f25f24 refactor: don't fail test in a goroutine
evgeniy-scherbinaff9eeb4 docs: fix ssh coder example in testing-templates doc (#17550)
EdwardAngert31b873f fix: add websocket close handling (#17548)
jaaydenh4fe770d ci: move go install tools to separate action (#17552)
ethanndickson8d8fc99 chore(dogfood): allow provider minor version updates (#17554)
matifaliaf32325 fix(examples/templates/docker-devcontainer): update folder path and p…
Aericio0826e8a feat: enable masking password inputs instead of blocking echo (#17469)
ibetitsmikecbb6c12 fix(examples/templates/kubernetes-devcontainer): update coder provide…
matifalie466844 docs: add automatic release calendar updates in docs (#17531)
matifalif24557b chore(dogfood): add windsurf module (#17558)
matifalifa65564 Merge branch 'main' of github.com:/coder/coder into yevhenii/512-clai…
dannykopping53b38d7 fix: use userCtx instead of prebuildCtx for claiming prebuild
evgeniy-scherbina6c41e03 refactor: CR's fixes
evgeniy-scherbina9173e9a CR's fixes
evgeniy-scherbinaFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
Refactoring
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commitc4595336d23e59f2de7d3d475ce67d257251dabf
There are no files selected for viewing
2 changes: 1 addition & 1 deletioncoderd/workspaces.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
99 changes: 20 additions & 79 deletionsenterprise/coderd/prebuilds/claim_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -10,13 +10,13 @@ import ( | ||
| "github.com/coder/quartz" | ||
| "github.com/google/uuid" | ||
| "github.com/stretchr/testify/require" | ||
| "github.com/coder/coder/v2/coderd/coderdtest" | ||
| "github.com/coder/coder/v2/coderd/database" | ||
| "github.com/coder/coder/v2/coderd/database/dbauthz" | ||
| "github.com/coder/coder/v2/coderd/database/dbtestutil" | ||
| agplprebuilds "github.com/coder/coder/v2/coderd/prebuilds" | ||
| "github.com/coder/coder/v2/coderd/rbac" | ||
| "github.com/coder/coder/v2/codersdk" | ||
| "github.com/coder/coder/v2/enterprise/coderd/coderdenttest" | ||
| @@ -78,40 +78,20 @@ func TestClaimPrebuild(t *testing.T) { | ||
| ) | ||
| cases := map[string]struct { | ||
| expectPrebuildClaimed bool | ||
| markPrebuildsClaimable bool | ||
| }{ | ||
| "no eligible prebuilds to claim": { | ||
| expectPrebuildClaimed: false, | ||
| markPrebuildsClaimable: false, | ||
| }, | ||
| "claiming an eligible prebuild should succeed": { | ||
| expectPrebuildClaimed: true, | ||
| markPrebuildsClaimable: true, | ||
| }, | ||
| "claiming an eligible prebuild results in error": { | ||
| expectPrebuildClaimed: true, | ||
| markPrebuildsClaimable: true, | ||
| }, | ||
evgeniy-scherbina marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| } | ||
| @@ -121,49 +101,26 @@ func TestClaimPrebuild(t *testing.T) { | ||
| t.Run(name, func(t *testing.T) { | ||
| t.Parallel() | ||
| // Setup. | ||
| ctx := testutil.Context(t, testutil.WaitMedium) | ||
evgeniy-scherbina marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| db, pubsub := dbtestutil.NewDB(t) | ||
| spy := newStoreSpy(db) | ||
| expectedPrebuildsCount := desiredInstances * presetCount | ||
| logger := testutil.Logger(t) | ||
| client, _,api, owner := coderdenttest.NewWithAPI(t, &coderdenttest.Options{ | ||
| Options: &coderdtest.Options{ | ||
| IncludeProvisionerDaemon: true, | ||
| Database: spy, | ||
| Pubsub: pubsub, | ||
| }, | ||
| EntitlementsUpdateInterval: time.Second, | ||
| }) | ||
| reconciler := prebuilds.NewStoreReconciler(spy, pubsub, codersdk.PrebuildsConfig{}, logger, quartz.NewMock(t)) | ||
| var claimer agplprebuilds.Claimer = &prebuilds.EnterpriseClaimer{} | ||
| api.AGPL.PrebuildsClaimer.Store(&claimer) | ||
| version := coderdtest.CreateTemplateVersion(t, client, owner.OrganizationID, templateWithAgentAndPresetsWithPrebuilds(desiredInstances)) | ||
| _ = coderdtest.AwaitTemplateVersionJobCompleted(t, client, version.ID) | ||
| @@ -179,14 +136,8 @@ func TestClaimPrebuild(t *testing.T) { | ||
| // Given: the reconciliation state is snapshot. | ||
| state, err := reconciler.SnapshotState(ctx, spy) | ||
| require.NoError(t, err) | ||
| require.Len(t, state.Presets, presetCount) | ||
| // When: a reconciliation is setup for each preset. | ||
| for _, preset := range presets { | ||
| ps, err := state.FilterByPreset(preset.ID) | ||
| @@ -215,6 +166,7 @@ func TestClaimPrebuild(t *testing.T) { | ||
| agents, err := db.GetWorkspaceAgentsInLatestBuildByWorkspaceID(ctx, row.ID) | ||
| require.NoError(t, err) | ||
| // Workspaces are eligible once its agent is marked "ready". | ||
| for _, agent := range agents { | ||
| require.NoError(t, db.UpdateWorkspaceAgentLifecycleStateByID(ctx, database.UpdateWorkspaceAgentLifecycleStateByIDParams{ | ||
| ID: agent.ID, | ||
| @@ -225,9 +177,9 @@ func TestClaimPrebuild(t *testing.T) { | ||
| } | ||
| } | ||
| t.Logf("found %d running prebuilds so far, want %d", len(runningPrebuilds), expectedPrebuildsCount) | ||
| return len(runningPrebuilds) == expectedPrebuildsCount | ||
| }, testutil.WaitSuperLong, testutil.IntervalSlow) | ||
evgeniy-scherbina marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| // When: a user creates a new workspace with a preset for which prebuilds are configured. | ||
| @@ -243,21 +195,10 @@ func TestClaimPrebuild(t *testing.T) { | ||
| TemplateVersionPresetID: presets[0].ID, | ||
| ClaimPrebuildIfAvailable: true, // TODO: doesn't do anything yet; it probably should though. | ||
| }) | ||
| require.NoError(t, err) | ||
| coderdtest.AwaitWorkspaceBuildJobCompleted(t, userClient, userWorkspace.LatestBuild.ID) | ||
| // Then: a prebuild should have been claimed. | ||
| require.EqualValues(t, spy.claims.Load(), 1) | ||
| require.NotNil(t, spy.claims.Load()) | ||
evgeniy-scherbina marked this conversation as resolved. OutdatedShow resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| @@ -315,9 +256,9 @@ func TestClaimPrebuild(t *testing.T) { | ||
| rows, err := spy.GetRunningPrebuiltWorkspaces(ctx) | ||
| require.NoError(t, err) | ||
| t.Logf("found %d running prebuilds so far, want %d", len(rows), expectedPrebuildsCount) | ||
| return len(runningPrebuilds) == expectedPrebuildsCount | ||
| }, testutil.WaitSuperLong, testutil.IntervalSlow) | ||
| // Then: when restarting the created workspace (which claimed a prebuild), it should not try and claim a new prebuild. | ||
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.