Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: implement claiming of prebuilt workspaces#17458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
evgeniy-scherbina merged 38 commits intomainfromyevhenii/512-claim-prebuild
Apr 24, 2025

Conversation

evgeniy-scherbina
Copy link
Contributor

@evgeniy-scherbinaevgeniy-scherbina commentedApr 17, 2025•
edited
Loading

Copy link
Contributor

@dannykoppingdannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

First-pass review

Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
Signed-off-by: Danny Kopping <dannykopping@gmail.com>
evgeniy-scherbinaand others added19 commitsApril 23, 2025 15:35
from@NickSquangler and@angrycub on SlackCo-authored-by: EdwardAngert <17991901+EdwardAngert@users.noreply.github.com>
resolves#17508 Display an error in the UI that the websocket closed if the user isstill interacting with the dynamic parameters form<img width="795" alt="Screenshot 2025-04-23 at 17 57 25"src="https://github.com/user-attachments/assets/15362ddb-fe01-462e-8537-a48302c5c621"/>
I think using an older version of mockgen on the schmoder CI broke theworkflow, so I'm gonna sync it via this action, like we do with theother `make build` dependencies.
…rovider version constraint (#17553)Co-authored-by: M Atif Ali <me@matifali.dev>
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'd like to see one test addition incoderd/workspaces_test.go exercising the AGPL codepath.

I have some additional suggestions to the tests in theenterprise/coderd/prebuilds package, but apart from that I don't need to review again 👍

@evgeniy-scherbina
Copy link
ContributorAuthor

I'd like to see one test addition incoderd/workspaces_test.go exercising the AGPL codepath.

I have some additional suggestions to the tests in theenterprise/coderd/prebuilds package, but apart from that I don't need to review again 👍

I'll add that test in a follow-up PR.

@evgeniy-scherbinaevgeniy-scherbina merged commit118f12a intomainApr 24, 2025
29 checks passed
@evgeniy-scherbinaevgeniy-scherbina deleted the yevhenii/512-claim-prebuild branchApril 24, 2025 13:39
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 24, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@dannykoppingdannykoppingdannykopping left review comments

@johnstcnjohnstcnjohnstcn approved these changes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Claiming a Prebuilt Workspace for a User
9 participants
@evgeniy-scherbina@dannykopping@johnstcn@EdwardAngert@jaaydenh@ethanndickson@matifali@Aericio@ibetitsmike
[8]ページ先頭
©2009-2025 Movatter.jp