Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add opt-out option to new parameters form#17456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 11 commits intomainfromlilac/parameters-opt-out
Apr 21, 2025

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedApr 17, 2025•
edited
Loading

@aslilacaslilac changed the titlefeat: add new parameters form opt-outfeat: add opt-out option to new parameters formApr 18, 2025
@aslilacaslilac requested a review fromjaaydenhApril 18, 2025 19:23
@aslilacaslilac marked this pull request as ready for reviewApril 18, 2025 19:24
Copy link
Contributor

@jaaydenhjaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. 👍

Nit: the only thing I would change is the name ofNewFormContext toExperimentalFormContext

@aslilac
Copy link
MemberAuthor

yeah, you're definitely right 😅 "new" was a weird choice when we already have a name we're using in various places

@aslilacaslilac merged commitf6364a2 intomainApr 21, 2025
29 checks passed
@aslilacaslilac deleted the lilac/parameters-opt-out branchApril 21, 2025 16:44
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 21, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@jaaydenhjaaydenhjaaydenh approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add escape hatch in UI to opt-out of Parameters experiment
2 participants
@aslilac@jaaydenh
[8]ページ先頭
©2009-2025 Movatter.jp