Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test: ignore context.Canceled in acquireWithCancel#17448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
spikecurtis merged 1 commit intomainfromspike/internal-584
Apr 17, 2025
Merged
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletionprovisionerd/provisionerd_test.go
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1270,6 +1270,11 @@ func (a *acquireOne) acquireWithCancel(stream proto.DRPCProvisionerDaemon_Acquir
return nil
}
err := stream.Send(a.job)
assert.NoError(a.t, err)
// dRPC is racy, and sometimes will return context.Canceled after it has successfully sent the message if we cancel
// right away, e.g. in unit tests that complete. So, just swallow the error in that case. If we are canceled before
// the job was acquired, presumably something else in the test will have failed.
if !xerrors.Is(err, context.Canceled) {
assert.NoError(a.t, err)
}
return nil
}
Loading

[8]ページ先頭

©2009-2025 Movatter.jp