- Notifications
You must be signed in to change notification settings - Fork907
feat: add slider component#17431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. Just had one suggestion about removing a possible footgun with the base Shad implementation
| className={cn( | ||
| "relative flex w-full touch-none select-none items-center h-1.5", | ||
| className, | ||
| )} |
ParkreinerApr 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Do we want to split this off into three values, since two of the classes are actually behavioral and not just stylistic? I don't see a case where we would ever want those to be overridden
className={cn("relative flex w-full items-center h-1.5",className,"touch-none select-none",)}
I'd rather make a bad UX edge case impossible out of the gate, over optimizing for a use case that might not ever exist
67a9127 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
The slider component is part of the components supported by Dynamic Parameters
There are no Figma designs for the slider component. This is based on the shadcn slider.