Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: prevent null loading sync settings#17430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Emyrk merged 1 commit intomainfromstevenmasley/org_sync_settings_not_null
Apr 16, 2025

Conversation

Emyrk
Copy link
Member

@EmyrkEmyrk commentedApr 16, 2025•
edited
Loading

Nulls passed to the frontend caused a page to fail to load.

Record<string,string> can benil in golang 😢

Screenshot From 2025-04-16 15-40-44

Nulls passed to the frontend cause errors
@EmyrkEmyrk changed the titlechore: when saving sync settings, prevent nilchore: prevent null loading sync settingsApr 16, 2025
@EmyrkEmyrk requested a review fromaslilacApril 16, 2025 17:37
@Emyrk
Copy link
MemberAuthor

I am going to make guts handle these types more accurately

@stirby
Copy link
Collaborator

/cherry-pick release/2.21

@aslilac
Copy link
Member

I love it when myRecord<string, string> is actually secretly aRecord<string, string> | null

@Emyrk
Copy link
MemberAuthor

I love it when myRecord<string, string> is actually secretly aRecord<string, string> | null

I have a change to guts to do that. Hoping there's not too many UI changes...

@EmyrkEmyrk merged commitc4d3dd2 intomainApr 16, 2025
37 checks passed
@EmyrkEmyrk deleted the stevenmasley/org_sync_settings_not_null branchApril 16, 2025 19:39
gcp-cherry-pick-botbot pushed a commit that referenced this pull requestApr 16, 2025
Nulls passed to the frontend caused a page to fail to load.`Record<string,string>` can be `nil` in golang
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 16, 2025
@matifali
Copy link
Member

/cherry-pick release/2.20

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@EmyrkEmyrk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@Emyrk@stirby@aslilac@matifali
[8]ページ先頭
©2009-2025 Movatter.jp