- Notifications
You must be signed in to change notification settings - Fork920
chore: load 'assign_default' value from legacy value#17428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
If this value was set before v2.19.0, then assign_default was ina json field that would not match. And it would default to `false`.This corrects that.
/cherry-pick release/2.21 |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
coderd/idpsync/organizations_test.go Outdated
| t.Run("AssignDefault,False", func(t *testing.T) { | ||
| t.Parallel() | ||
| legacy := `{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
same here
Uh oh!
There was an error while loading.Please reload this page.
coderd/idpsync/organizations_test.go Outdated
| t.Run("CorrectAssign", func(t *testing.T) { | ||
| t.Parallel() | ||
| legacy := `{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
same here
Co-authored-by: ケイラ <mckayla@hey.com>
2e5cd29 intomainUh oh!
There was an error while loading.Please reload this page.
Cherry-pick failed with |
If this value was set before v2.19.0, then assign_default was in a json field that would not match. And it would default to
false. This corrects that.