Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: don't attempt to insert empty terraform plans into the database#17426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 1 commit intomainfromlilac/skip-empty-plan
Apr 16, 2025

Conversation

@aslilac
Copy link
Member

if you're using an external provisioner that doesn't provide plan information, we should just skip the insert rather than fail.

@Emyrk
Copy link
Member

If we do not insert it, does that fail a lookup query later?

Meaning, can we omit that insert? That is safe?

@aslilac
Copy link
MemberAuthor

@Emyrk we already have to operate under the assumption that this might be missing to support template versions that were built before we added this feature, so we check forsql.ErrNoRows and ignore it, defaulting to{}.

Emyrk reacted with thumbs up emoji

@aslilacaslilac merged commit2a76f50 intomainApr 16, 2025
31 checks passed
@aslilacaslilac deleted the lilac/skip-empty-plan branchApril 16, 2025 16:14
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 16, 2025
@matifali
Copy link
Member

/cherry-pick release/2.21

@matifali
Copy link
Member

/cherry-pick release/2.20

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@aslilacaslilac

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aslilac@Emyrk@matifali
[8]ページ先頭
©2009-2025 Movatter.jp