- Notifications
You must be signed in to change notification settings - Fork905
fix: don't attempt to insert empty terraform plans into the database#17426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
If we do not insert it, does that fail a lookup query later? Meaning, can we omit that insert? That is safe? |
@Emyrk we already have to operate under the assumption that this might be missing to support template versions that were built before we added this feature, so we check for |
2a76f50 intomainUh oh!
There was an error while loading.Please reload this page.
/cherry-pick release/2.21 |
/cherry-pick release/2.20 |
if you're using an external provisioner that doesn't provide plan information, we should just skip the insert rather than fail.