- Notifications
You must be signed in to change notification settings - Fork905
feat: modify config-ssh to check for Coder Connect#17419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
spikecurtis commentedApr 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
efdb86b
to3073db4
Compareecef684
to169ab02
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Awesome! Tried it out and seems to work well. This also (perhaps inadvertently) fixes most issues when trying to connect to stopped workspaces as it will automatically proxy the first time and trigger autostart. 😄
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Edit: Just realized that setting
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM after the-o
settings are added to the non-proxycommand.
It'd be nice to have two entries in the SSH config, i.e:
Host *.coder Foo=BarMatch host *.coder !exec "/Users/maf/Code/coder/coder connect exists %h"...
It's confusing that this works, I thought the rule was whatever Host appeared first in the config was used, so that this would never hit the match block. Apparently not.
This also (perhaps inadvertently) fixes most issues when trying to connect to stopped workspaces as it will automatically proxy the first time and trigger autostart.
This is sick
169ab02
toa89e1c3
Compare3073db4
to2bb6713
Comparea89e1c3
todc5fab3
Compare2bb6713
toafbcc03
Compareafbcc03
toa8cf4c3
Comparedc5fab3
to3b54254
Comparea8cf4c3
toc4e9eeb
CompareOk, now looks like
|
c4e9eeb
to77364ba
Compareb0854aa
intomainUh oh!
There was an error while loading.Please reload this page.
Merge activity
|
@spikecurtis works as expected now, thanks! It'd be nice to move those default ones (at least ConnectTimeout, StrictHostKeyChecking, and UserKnownHostsFile, but probably LogLevel too) to the match block though, since host key verification works well over Coder Connect (seems a shame to disable it) and the others are most likely related to proxying as well. |
Honestly, we can probably retire |
Oh yeah, I thought it was still a requirement for the proxy command but it seems you are right, we can totally do that! I think the |
Uh oh!
There was an error while loading.Please reload this page.
relates to#16828
Changes SSH config so that suffixes only match if Coder Connect is not running / available. This means that we will use the existing Coder Connect tunnel if it is available, rather than creating a new tunnel via
coder ssh --stdio
.