- Notifications
You must be signed in to change notification settings - Fork905
feat: add coder connect exists hidden subcommand#17418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
spikecurtis commentedApr 16, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
ecef684 to169ab02CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM! 👍🏻
| @@ -175,6 +181,10 @@ func (r *RootCmd) RunWithSubcommands(subcommands []*serpent.Command) { | |||
| //nolint:revive,gocritic | |||
| os.Exit(code) | |||
| } | |||
| if errors.Is(err, ErrSilent) { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
&exitError{code: 1} could potentially be used instead, but I see other uses of it have disappeared from the code base.
169ab02 toa89e1c3Comparea89e1c3 todc5fab3Compare3b54254 intomainUh oh!
There was an error while loading.Please reload this page.
Merge activity
|
Uh oh!
There was an error while loading.Please reload this page.
Adds a new hidden subcommand
coder connect exists <hostname>that checks if the name exists via Coder Connect. This will be used in SSH config to match only if Coder Connect is unavailable for the hostname in question, so that the SSH client will directly dial the workspace over an existing Coder Connect tunnel.Also refactors the way we inject a test DNS resolver into the lookup functions so that we can test from outside the
workspacesdkpackage.