- Notifications
You must be signed in to change notification settings - Fork906
refactor: update the workspace table design#17404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| Name | ||
| </div> | ||
| </TableHead> | ||
| {hasAppStatus && <TableHead className="w-[30%]">Activity</TableHead>} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Another way to handle the column widths is like this<TableHead className="w-2/5">IdP organization</TableHead> <TableHead className="w-3/5">Coder organization</TableHead> <TableHead className="w-auto" />
@BrunoQuaresma Are you planning on updating the row height in a separate PR? I noticed in the new design the row height is 72px but currently it is 64px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Overall, looks good. just a few small comments.
why is the border on the top row thicker in the screenshot? |
This is the new row hover design. |
BrunoQuaresma commentedApr 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
But the offset width was wrong (@aslilac has an awesome robotic eye). Since we are not using the TailwindCSS preflight, I had to use the |
b0fe626 intomainUh oh!
There was an error while loading.Please reload this page.
Related to#17309
Before:
After:
