- Notifications
You must be signed in to change notification settings - Fork907
feat: setup connection to dynamic parameters websocket#17393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
20 commits Select commitHold shift + click to select a range
7b61485
feat: create dynamic parameter component
jaaydenhf5d4a1c
fix: format
jaaydenh0fc4289
chore: cleanup, update validation
jaaydenhd109874
chore: update for types from typesGenerated
jaaydenh7c13eb7
fix: remove filters
jaaydenh4290284
chore: remove unused typesParameter.ts
jaaydenh74084fb
fix: updates for PR review
jaaydenh05adc15
fix: format
jaaydenhb2c662a
fix: remove websocket code
jaaydenh2da7d99
feat: connect to dynamic parameters websocket
jaaydenh98dfee2
chore: cleanup
jaaydenhd1ada89
fix: set initial values
jaaydenhe04ce2f
fix: fix commit
jaaydenha6f480d
fix: fix rebase issues
jaaydenh2613100
chore: update valid value methods
jaaydenh1e66a71
chore: onError is required
jaaydenh9a9201e
chore: display websocket error in UI
jaaydenh1777ca9
fix: format
jaaydenh440fedc
fix: updates for PR review
jaaydenh4f056af
chore: add useCallback
jaaydenhFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
26 changes: 26 additions & 0 deletionssite/src/api/api.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
23 changes: 12 additions & 11 deletionssite/src/modules/workspaces/DynamicParameter/DynamicParameter.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
58 changes: 52 additions & 6 deletionssite/src/pages/CreateWorkspacePage/CreateWorkspacePageExperimental.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
18 changes: 4 additions & 14 deletionssite/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.