Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: setup connection to dynamic parameters websocket#17393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 20 commits intomainfromjaaydenh/dynamic-params-websocket
Apr 16, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedApr 14, 2025•
edited
Loading

@jaaydenhjaaydenh self-assigned thisApr 14, 2025
@jaaydenhjaaydenh marked this pull request as ready for reviewApril 14, 2025 20:38
@jaaydenhjaaydenh requested a review fromaslilacApril 14, 2025 20:38
Base automatically changed fromjaaydenh/dynamic-parameter-component tomainApril 16, 2025 09:00
@jaaydenhjaaydenhforce-pushed thejaaydenh/dynamic-params-websocket branch froma39b095 toe04ce2fCompareApril 16, 2025 09:17
@jaaydenhjaaydenh requested a review fromaslilacApril 16, 2025 14:43
@jaaydenhjaaydenhforce-pushed thejaaydenh/dynamic-params-websocket branch from266620a to440fedcCompareApril 16, 2025 16:32
Comment on lines 113 to 125
const sendMessage = (formValues: Record<string, string>) => {
setWSResponseId((prevId) => {
const request: DynamicParametersRequest = {
id: prevId + 1,
inputs: formValues,
};
if (ws.current && ws.current.readyState === WebSocket.OPEN) {
ws.current.send(JSON.stringify(request));
return prevId + 1;
}
return prevId;
});
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

one last thought, I noticed thatonMessage is wrapped in auseCallback but this isn't. was that intentional? could be nice to wrap this one as well since it's also being passed as a prop to a child 🤷‍♀️

jaaydenh reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

onMessage was wrapped because its used as a dependency for a useEffect. Sure I can wrap sendMessage as well.

@jaaydenhjaaydenh merged commit3d787da intomainApr 16, 2025
29 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/dynamic-params-websocket branchApril 16, 2025 16:49
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Connect Experimental Workspace Create Page with new coder websocket
2 participants
@jaaydenh@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp