- Notifications
You must be signed in to change notification settings - Fork927
chore: add logging for coderdtest server lifecycle#17376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
chore: add logging for coderdtest server lifecycle#17376
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -421,6 +421,7 @@ func NewOptions(t testing.TB, options *Options) (func(http.Handler), context.Can | |||
| handler.ServeHTTP(w, r) | |||
| } | |||
| })) | |||
| t.Logf("coderdtest server listening on %s", srv.Listener.Addr().String()) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
suggestion: extract for later re-use indefer() below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm paranoid, and would prefer to re-query them.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
d8fcb06 intomainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
regardingcoder/internal#581
Adds logging around the lifecyle of the coderd HTTP server.