Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: fill out workspace owner data for dynamic parameters#17366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
aslilac merged 10 commits intomainfromlilac/parameters-owner
Apr 17, 2025

Conversation

aslilac
Copy link
Member

@aslilacaslilac commentedApr 11, 2025•
edited
Loading

@aslilacaslilac changed the base branch frommain tolilac/testutil-chanApril 15, 2025 21:59
@aslilacaslilacforce-pushed thelilac/parameters-owner branch from8f3f1a1 to1820c3dCompareApril 15, 2025 22:19
@aslilacaslilac requested a review fromEmyrkApril 16, 2025 15:34
Base automatically changed fromlilac/testutil-chan tomainApril 16, 2025 16:37
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just need to fixup the roles fetched.

And ideally, maybe in another PR, we should refactor the fetching code to be the same implementation as used in the provisioner

@aslilacaslilac requested a review fromEmyrkApril 17, 2025 19:59
@aslilacaslilac merged commit2cc56ab intomainApr 17, 2025
33 of 34 checks passed
@aslilacaslilac deleted the lilac/parameters-owner branchApril 17, 2025 20:51
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 17, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@EmyrkEmyrkEmyrk approved these changes

Assignees

@aslilacaslilac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

parameters: provide user data to evaluator
2 participants
@aslilac@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp