Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(codersdk/toolsdk): fix tool schemata#17365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 2 commits intomainfromcj/mcp/fix-schema
Apr 11, 2025
Merged

Conversation

johnstcn
Copy link
Member

@johnstcnjohnstcn commentedApr 11, 2025
edited
Loading

Fixes two issues with the MCP server:

  • Ensures we have a non-null schema, as the following schema was making claude-code unhappy:
        "inputSchema": { "type": "object", "properties": null },
  • Skip adding the coder_report_task tool if an agent client is not available. Otherwise the agent may try to report tasks and get confused.

Copy link

@cdr-botcdr-botbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@johnstcnjohnstcn merged commit7b0422b intomainApr 11, 2025
35 checks passed
@johnstcnjohnstcn deleted the cj/mcp/fix-schema branchApril 11, 2025 17:58
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 11, 2025
@@ -259,6 +259,10 @@ is provisioned correctly and the agent can connect to the control plane.
Tool: aisdk.Tool{
Name: "coder_list_templates",
Description: "Lists templates for the authenticated user.",
Schema: aisdk.Schema{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

ANewSchema function or a builder in aisdk might be a good idea.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bcpeinhardtbcpeinhardtbcpeinhardt left review comments

@cdr-botcdr-bot[bot]cdr-bot[bot] approved these changes

@kylecarbskylecarbsAwaiting requested review from kylecarbs

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@johnstcn@bcpeinhardt@kylecarbs

[8]ページ先頭

©2009-2025 Movatter.jp