Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add IsCoderConnectRunning to workspacesdk#17361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

spikecurtis
Copy link
Contributor

@spikecurtisspikecurtis commentedApr 11, 2025•
edited
Loading

AddsIsCoderConnectRunning() to the workspacesdk. This will support thecoder CLI being able to use CoderConnect when it's running.

part of#16828

@spikecurtisGraphite App
Copy link
ContributorAuthor

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

@spikecurtisspikecurtis marked this pull request as ready for reviewApril 11, 2025 12:32
Copy link
Member

@ethanndicksonethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

👍

ICYMI (as I did), we still need to addHostnameSuffix to the generic DNS record

@spikecurtis
Copy link
ContributorAuthor

👍

ICYMI (as I did), we still need to addHostnameSuffix to the generic DNS record

Added this in#17335 during a merge after you already reviewed. Sorry I didn't point it out.

@spikecurtisspikecurtis merged commite5ce382 intomainApr 14, 2025
35 of 36 checks passed
@spikecurtisspikecurtis deleted the spike/host-suffix/is-coder-connect-running branchApril 14, 2025 05:47
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 14, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

Assignees

@spikecurtisspikecurtis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@spikecurtis@ethanndickson
[8]ページ先頭
©2009-2025 Movatter.jp