NotificationsYou must be signed in to change notification settings
Fork906
Star10k

chore(codersdk): deprecate WorkspaceAppStatus.{NeedsUserAttention,Icon}#17358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

johnstcn merged 3 commits intomainfromcj/task-status/remove-unused-fields

Apr 15, 2025

Merged

chore(codersdk): deprecate WorkspaceAppStatus.{NeedsUserAttention,Icon}#17358

johnstcn merged 3 commits intomainfromcj/task-status/remove-unused-fields

Apr 15, 2025

Conversation

Copy link

Member

johnstcn commentedApr 11, 2025•
edited
Loading

#17163 introduced theworkspace_app_statuses table. Two of these fields (needs_user_attention,icon) turned out to be surplus to requirements.

Removes columnsneeds_user_attention andicon fromworkspace_app_statuses
Marks the corresponding fields ofcodersdk.WorkspaceAppStatus as deprecated.

github-actionsbot assignedjohnstcn

Apr 11, 2025

johnstcn changed the title~~chore(codersdk): remove NeedsUserAttention and Icon from WorkspaceAppStatus~~chore(codersdk): deprecate WorkspaceAppStatus.{NeedsUserAttention,Icon}

Apr 11, 2025

johnstcn force-pushed thecj/task-status/remove-unused-fields branch from101cf64 toc9ffa9bCompare

April 11, 2025 10:53

johnstcn requested review fromCopilot andmafredri

April 11, 2025 10:54

CopilotAI reviewed

Apr 11, 2025

View reviewed changes

Copy link

Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 15 out of 20 changed files in this pull request and generated 1 comment.

Files not reviewed (5)

coderd/apidoc/swagger.json: Language not supported
coderd/database/dump.sql: Language not supported
coderd/database/migrations/000317_workspace_app_status_drop_fields.down.sql: Language not supported
coderd/database/migrations/000317_workspace_app_status_drop_fields.up.sql: Language not supported
coderd/database/queries/workspaceapps.sql: Language not supported