Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: create dynamic parameter component#17351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 13 commits intomainfromjaaydenh/dynamic-parameter-component
Apr 16, 2025

Conversation

jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedApr 10, 2025•
edited
Loading

  • Create DynamicParameter component and test with locally run preview websocket.
  • Adapt CreateWorkspacePageExperimental to work with PreviewParameter instead of TemplateVersionParameter
  • Small changes to checkbox, multi-select combobox and radiogroup

The websocket implementation is temporary for testing purpose with a locally run preview websocket

@jaaydenhjaaydenh self-assigned thisApr 10, 2025
@jaaydenhjaaydenhforce-pushed thejaaydenh/dynamic-parameter-component branch 2 times, most recently from80e9dbd to250ee53CompareApril 11, 2025 20:20
@jaaydenhjaaydenhforce-pushed thejaaydenh/dynamic-parameter-component branch from250ee53 todd5147dCompareApril 11, 2025 20:53
@jaaydenhjaaydenh requested a review fromaslilacApril 11, 2025 21:02
@jaaydenhjaaydenh marked this pull request as ready for reviewApril 11, 2025 21:02
Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if the current implementation ofuseWebSocket is not meant to be a production ready React WebSocket binding, we should make that a lot clearer. it's half actually connecting to a websocket and half just using testdata? I'm confused on what it really wants to be

@jaaydenhjaaydenh requested a review fromaslilacApril 15, 2025 17:01
@jaaydenhjaaydenhforce-pushed thejaaydenh/dynamic-parameter-component branch from84c4abe tob7d0d32CompareApril 15, 2025 17:37
@jaaydenhjaaydenhforce-pushed thejaaydenh/dynamic-parameter-component branch from762aa3a to2a35fe2CompareApril 15, 2025 19:14
@jaaydenhjaaydenh merged commit1db70be intomainApr 16, 2025
29 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/dynamic-parameter-component branchApril 16, 2025 09:00
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 16, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@jaaydenhjaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jaaydenh@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp