Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add edit-role within user command#17341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

brettkolodny
Copy link
Contributor

@brettkolodnybrettkolodny commentedApr 10, 2025•
edited
Loading

Closescoder/internal #207

CleanShot.2025-04-11.at.14.30.24.mp4

@brettkolodnybrettkolodny marked this pull request as draftApril 10, 2025 15:01
@brettkolodnybrettkolodny marked this pull request as ready for reviewApril 10, 2025 15:13
Copy link
Member

@aslilacaslilac left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

to me, this sounds like it would edit their site-wide roles, not organization scoped roles. also, single organization deployments actually can't assign org-scoped roles. 🤔

I think the wording in the original ticket was a bit misleading/misguided. this shouldn't be an alias, it should be a new command that edits site wide roles.

@brettkolodny
Copy link
ContributorAuthor

Ah gotcha, thank you for the clarification!

@brettkolodnybrettkolodny changed the titlefeat: alias the organization edit-role command within the user commandfeat: add edit-role within user commandApr 11, 2025
@brettkolodny
Copy link
ContributorAuthor

Implemented a newedit-roles command as suggested

Copy link
Member

@aslilacaslilac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good, but needs tests!

Copy link
Member

@aslilacaslilac left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

awesome! thanks!

@brettkolodnybrettkolodny merged commit70b113d intomainApr 15, 2025
31 checks passed
@brettkolodnybrettkolodny deleted the brett-i207/add-coder-user-edit-role-command-for-edit branchApril 15, 2025 22:30
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 15, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@aslilacaslilacaslilac approved these changes

Assignees

@brettkolodnybrettkolodny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Addcoder user edit-role command for editing user roles in CLI
2 participants
@brettkolodny@aslilac
[8]ページ先頭
©2009-2025 Movatter.jp