Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

refactor(agent/agentcontainers): implement API service#17340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedApr 10, 2025•
edited
Loading

This refactor improves separation of API and containers with minimal changes to logic.

Not a lot of code was changed, so here are the highlights:

  • Routes are now defined inagentcontainers package
  • Handler renamed to API
  • API lazy init was moved into NewAPI
  • Tests that don't need to be internal were made external

Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

@mafredrimafredri changed the titlerefactor(agent/agentcontainers): Implement API servicerefactor(agent/agentcontainers): implement API serviceApr 10, 2025
@mafredrimafredriforce-pushed themafredri/feat-agent-recreate-devcontainer-refactor branch from2b7316b to31c7bffCompareApril 10, 2025 15:05
@mafredrimafredri marked this pull request as ready for reviewApril 10, 2025 15:16
Copy link
Member

@johnstcnjohnstcn left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, will approve once tests run 👍 (EDIT: looks like they did previously)

@mafredrimafredri merged commit60fbe67 intomainApr 11, 2025
29 checks passed
@mafredrimafredri deleted the mafredri/feat-agent-recreate-devcontainer-refactor branchApril 11, 2025 08:41
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 11, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

Copilot code reviewCopilotCopilot left review comments

@johnstcnjohnstcnjohnstcn approved these changes

@DanielleMaywoodDanielleMaywoodAwaiting requested review from DanielleMaywood

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@mafredri@johnstcn
[8]ページ先頭
©2009-2025 Movatter.jp