Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

docs: add docs preview GitHub action#17317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
EdwardAngert wants to merge5 commits intomainfromsimplified-docs-preview

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngertEdwardAngert commentedApr 9, 2025
edited
Loading

Summary

This PR adds a simplified docs preview GitHub action that comments on PRs with Vercel preview links when documentation changes. It improves upon the more complex implementation in PR#17282 by:

  • Focusing on the core functionality of providing Vercel preview links
  • Using established GitHub Actions like tj-actions/changed-files
  • Implementing proper security practices without overcomplication
  • Highlighting newly added documentation referenced in manifest.json

The action will:

  1. Detect when documentation files change in a PR
  2. Generate Vercel preview links for changed documents
  3. Create (or update) a PR comment with links to previews
  4. Highlight newly added documentation when manifest.json changes

Future iterations will:

  • Consolidate shared actions in a workflow that runs first

Test plan

  • Create a PR that modifies docs files
  • Verify the action runs and comments on the PR with preview links
  • Modify manifest.json to add a new doc and verify it's highlighted in the comment

🤖 Generated withClaude Code

Creates a simplified docs preview action that comments on PRs with Vercel preview links.The action shows changed files and highlights newly added documentation from manifest.json.🤖 Generated with [Claude Code](https://claude.ai/code)Co-Authored-By: Claude <noreply@anthropic.com>
@EdwardAngertEdwardAngert changed the titleAdd simplified docs preview GitHub actiondocs: add docs preview GitHub actionApr 9, 2025
EdwardAngertand others added4 commitsApril 9, 2025 14:33
…o use the same SHA and version (v45.0.7) that the docs-ci.yaml workflow uses.\n\n\ud83e\udd16 Generated with [Claude Code](https://claude.ai/code)\n\nCo-Authored-By: Claude <noreply@anthropic.com>\
…d to match patterns from the successful pr-deploy.yaml workflow:\n- Added job-level pull-requests write permission\n- Added explicit env var for PR_NUMBER\n- Added explicit GITHUB_TOKEN environment variable\n- Added reactions-edit-mode for consistency\n\n\ud83e\udd16 Generated with [Claude Code](https://claude.ai/code)\n\nCo-Authored-By: Claude <noreply@anthropic.com>\
@EdwardAngert
Copy link
ContributorAuthor

testing against this PR in#17319

2025-04-09_15-56-17

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we plan to reuse this action anywhere else? If not I would move it to the main workflow file.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

this PR's just to get it started - we've got another PR with workflow improvements in#17322

@matifalimatifali removed their request for reviewApril 16, 2025 07:40
@EdwardAngertEdwardAngert marked this pull request as draftApril 22, 2025 18:00
EdwardAngert added a commit that referenced this pull requestApr 23, 2025
Combines features from PRs#17317,#17322, and#17370:- Adds Vale style checking for documentation- Creates a reusable workflow for documentation validation- Optimizes PR checks and post-merge validation- Adds automatic GitHub issue creation for broken links- Updates all documentation checks to run in a structured mannerThis PR supersedes:- PR#17317: Docs Preview GitHub Action- PR#17322: Shared Docs GitHub Action- PR#17370: Vale Style Checking and Docs Workflow Improvements
@EdwardAngert
Copy link
ContributorAuthor

replaced by#17522

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 23, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@matifalimatifalimatifali left review comments

@bpmctbpmctAwaiting requested review from bpmct

@stirbystirbyAwaiting requested review from stirby

Assignees

@EdwardAngertEdwardAngert

Labels
docs/sitedocs site-related issue/task/feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@EdwardAngert@matifali

[8]ページ先頭

©2009-2025 Movatter.jp