Apr 9, 2025 · Apr 9, 2025 · Apr 9, 2025 · Apr 9, 2025
diff --git a/agent/agentssh/agentssh_test.go b/agent/agentssh/agentssh_test.go
 "strings"
 "sync"
 "testing"
 "time"

 "github.com/prometheus/client_golang/prometheus"
 "github.com/spf13/afero"
 }
 assert.NoError(t, err)

 // Allow the session to settle (i.e. reach echo).
 pty.ExpectMatchContext(ctx, "started")
 // Sleep a bit to ensure the sleep has started.
 time.Sleep(testutil.IntervalMedium)

 close(ch)

 err = sess.Wait()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -13,6 +13,7 @@ import (
		"strings"
		"sync"
		"testing"
		"time"

		"github.com/prometheus/client_golang/prometheus"
		"github.com/spf13/afero"
Expand DownExpand Up		@@ -200,7 +201,11 @@ func TestNewServer_CloseActiveConnections(t *testing.T) {
		}
		assert.NoError(t, err)

		// Allow the session to settle (i.e. reach echo).
		pty.ExpectMatchContext(ctx, "started")
		// Sleep a bit to ensure the sleep has started.
		time.Sleep(testutil.IntervalMedium)
Copy link Member johnstcnApr 9, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. nit: maybe we should only sleep on`runtime.GOOS == "darwin"`? Copy link MemberAuthor mafredriApr 9, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I kind of agree, but also worry about this being a very hard to trigger edge case on other OS's as well :/.

		close(ch)

		err = sess.Wait()
Expand Down