- Notifications
You must be signed in to change notification settings - Fork1k
test(agent/agentssh): fix macos signal flake during close#17313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
I haven't been able to verify this fix, but I'm hoping this'll do it.Fixescoder/internal#558
| // Allow the session to settle (i.e. reach echo). | ||
| pty.ExpectMatchContext(ctx,"started") | ||
| // Sleep a bit to ensure the sleep has started. | ||
| time.Sleep(testutil.IntervalMedium) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit: maybe we should only sleep onruntime.GOOS == "darwin"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I kind of agree, but also worry about this being a very hard to trigger edge case on other OS's as well :/.
98c05b3 intomainUh oh!
There was an error while loading.Please reload this page.
I haven't been able to verify this fix, but I'm hoping this'll do it.
Fixescoder/internal#558