Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(agent): implement recreate for devcontainers#17308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mafredri merged 13 commits intomainfrommafredri/feat-agent-recreate-devcontainer
Apr 10, 2025

Conversation

mafredri
Copy link
Member

@mafredrimafredri commentedApr 9, 2025•
edited
Loading

This change implements an interface for running@devcontainers/cli up and an API endpoint on the agent for triggering recreate for a running devcontainer.

A couple of limitations:

  1. Synchronous HTTP request, meaning the browser might choose to time it out before it's done => no result/error (and devcontainer cli command probably gets killed via ctx cancel).
  2. Logs are only written to agent logs via slog, not as a "script" in the UI.

Both 1 and 2 will be improved in future refactors.

Fixescoder/internal#481
Fixescoder/internal#482

@mafredrimafredriforce-pushed themafredri/feat-agent-recreate-devcontainer branch 2 times, most recently from91dfec3 to0098663CompareApril 9, 2025 15:43
@mafredrimafredriforce-pushed themafredri/feat-agent-recreate-devcontainer branch from0098663 to6d18522CompareApril 9, 2025 15:55
@mafredrimafredri marked this pull request as ready for reviewApril 9, 2025 15:55
Copy link
Contributor

@DanielleMaywoodDanielleMaywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

looks good to me 👍

Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice work! I especially like the test helper thing you added 👍

return
}

containers, err := ch.cl.List(ctx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Potential follow-up (non-blocking): I wonder if we should also add anInspect() method to theLister; listing the entire containers endpoint is probably wasteful.

mafredri reacted with thumbs up emoji
@mafredrimafredriforce-pushed themafredri/feat-agent-recreate-devcontainer branch frome2d5de8 tof5e2328CompareApril 10, 2025 10:15
@mafredrimafredri merged commit25fb34c intomainApr 10, 2025
29 checks passed
@mafredrimafredri deleted the mafredri/feat-agent-recreate-devcontainer branchApril 10, 2025 13:16
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 10, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@DanielleMaywoodDanielleMaywoodDanielleMaywood approved these changes

Assignees

@mafredrimafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

coderd: expose agent v0 rest api endpoint to recreate a devcontainer agent: support recreating a running devcontainer
3 participants
@mafredri@johnstcn@DanielleMaywood
[8]ページ先頭
©2009-2025 Movatter.jp