- Notifications
You must be signed in to change notification settings - Fork1k
fix(site): resolve allArray.prototype.toSorted andArray.prototype.sort bugs#17307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| key={usage.slug} | ||
| css={{display:"flex",gap:24,alignItems:"center"}} | ||
| > | ||
| {validUsage.map((usage,i)=>{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
None of the code content changed here. The indentation only changed because I moved the.sort call up, to make it more obvious that it wasn't causing any harmful mutations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM 👍
a03a54d intomainUh oh!
There was an error while loading.Please reload this page.
Closes#16759
Changes made
Array.prototype.toSortedwithArray.prototype.sortto provide better support for older browsersArray.prototype.sortcalls where necessary to remove risks of mutation render bugs.sortcalls are harmless and don't have any risks