Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(coderd/notifications): group workspace build failure report#17306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywoodDanielleMaywood commentedApr 9, 2025•
edited
Loading

Closes#15745

Instead of sending X many reports to a single template admin, we instead send only 1.

image

Instead of sending X many reports to a single template admin, we insteadsend only 1.
@DanielleMaywoodDanielleMaywood changed the titlefeat(notifications): group workspace build failure reportfeat(coderd/notifications): group workspace build failure reportApr 9, 2025
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (3)
  • coderd/database/migrations/000316_group_build_failure_notifications.up.sql: Language not supported
  • coderd/notifications/testdata/rendered-templates/smtp/TemplateWorkspaceBuildsFailedReport.html.golden: Language not supported
  • coderd/notifications/testdata/rendered-templates/webhook/TemplateWorkspaceBuildsFailedReport.json.golden: Language not supported
Comments suppressed due to low confidence (1)

coderd/notifications/notifications_test.go:1014

  • The key 'template_version_count' appears inconsistent with similar keys such as 'template_version_name'. Consider renaming it for consistency.
"template_version_count": "bobby-template-version-2",

@DanielleMaywoodDanielleMaywood marked this pull request as ready for reviewApril 10, 2025 10:53
Copy link
Member

@mtojekmtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@DanielleMaywoodDanielleMaywood merged commit6dd1056 intomainApr 10, 2025
28 checks passed
@DanielleMaywoodDanielleMaywood deleted the dm-group-build-failures-into-single-report branchApril 10, 2025 12:32
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 10, 2025
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Post-merge 👍

@stirby
Copy link
Collaborator

/cherry-pick release/2.21

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@johnstcnjohnstcnjohnstcn left review comments

Copilot code reviewCopilotCopilot left review comments

@mtojekmtojekmtojek approved these changes

Assignees

@DanielleMaywoodDanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template build failure notifications aren't grouped
4 participants
@DanielleMaywood@stirby@johnstcn@mtojek
[8]ページ先頭
©2009-2025 Movatter.jp