Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore(cli): increase healthcheck timeout in TestSupportbundle#17291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
johnstcn merged 5 commits intomainfromcj/flake/cli/support/NoAgent
Apr 9, 2025

Conversation

johnstcn
Copy link
Member

Fixescoder/internal#272

  • Increases healthcheck timeout in tests. This seems to be the most usual cause of test failures.
  • Adds a non-nilness check before caching a healthcheck report.
  • Modifies the HTTP response code to 503 (was 404) when no healthcheck report is available. 503 seems to be a better indicator of the server state in this case, whereas 404 could be misinterpreted as a typo in the healthcheck URL.

@johnstcnjohnstcn self-assigned thisApr 8, 2025
@johnstcnjohnstcn changed the titlechore(cli): TestSupportbundle: fix test flakeschore(cli): increase healthcheck timeout in TestSupportbundleApr 8, 2025
@johnstcnjohnstcn merged commita8fbe71 intomainApr 9, 2025
29 checks passed
@johnstcnjohnstcn deleted the cj/flake/cli/support/NoAgent branchApril 9, 2025 08:21
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 9, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@ethanndicksonethanndicksonethanndickson approved these changes

@mafredrimafredriAwaiting requested review from mafredri

Assignees

@johnstcnjohnstcn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake:TestSupportBundle/NoWorkspace: health report should not be empty
2 participants
@johnstcn@ethanndickson

[8]ページ先頭

©2009-2025 Movatter.jp