Apr 8, 2025 · Apr 8, 2025 · Apr 8, 2025 · Apr 8, 2025
diff --git a/agent/agent_test.go b/agent/agent_test.go
 s, ok := <-stats
 t.Logf("got stats: ok=%t, ConnectionCount=%d, RxBytes=%d, TxBytes=%d, SessionCountVSCode=%d, ConnectionMedianLatencyMS=%f",
 ok, s.ConnectionCount, s.RxBytes, s.TxBytes, s.SessionCountVscode, s.ConnectionMedianLatencyMs)
 return ok && s.ConnectionCount > 0 && s.RxBytes > 0 && s.TxBytes > 0 &&
 return ok &&
 // Ensure that the connection didn't count as a "normal" SSH session.
 // This was a special one, so it should be labeled specially in the stats!
 s.SessionCountVscode == 1 &&
 s, ok := <-stats
 t.Logf("got stats with conn open: ok=%t, ConnectionCount=%d, SessionCountJetBrains=%d",
 ok, s.ConnectionCount, s.SessionCountJetbrains)
 return ok && s.ConnectionCount > 0 &&
 s.SessionCountJetbrains == 1
 return ok && s.SessionCountJetbrains == 1
 }, testutil.WaitLong, testutil.IntervalFast,
 "never saw stats with conn open",
 )
Original file line number	Diff line number	Diff line change
Expand Up		@@ -190,7 +190,7 @@ func TestAgent_Stats_Magic(t *testing.T) {
		s, ok := <-stats
		t.Logf("got stats: ok=%t, ConnectionCount=%d, RxBytes=%d, TxBytes=%d, SessionCountVSCode=%d, ConnectionMedianLatencyMS=%f",
Copy link Member johnstcnApr 8, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. We should probably also remove these fields (ConnectionCount, RxBytes, TxBytes) from the`t.Logf` as well as they're not relevant to this test. If we need to introspect in more detail, a debugger is probably a better option. Copy link ContributorAuthor spikecurtisApr 8, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I disagree --- although we shouldn't be asserting their values, it can be useful to see them in logs so you can tell the difference between a test that misclassifies the VSCode session from one where we fail to connect at all, or fail to get any meaningful stats. The debugger is great, but relatively useless for diagnosing rare-ish flakes.
		ok, s.ConnectionCount, s.RxBytes, s.TxBytes, s.SessionCountVscode, s.ConnectionMedianLatencyMs)
		return ok && s.ConnectionCount > 0 && s.RxBytes > 0 && s.TxBytes > 0 &&
		return ok &&
		// Ensure that the connection didn't count as a "normal" SSH session.
		// This was a special one, so it should be labeled specially in the stats!
		s.SessionCountVscode == 1 &&
Expand DownExpand Up		@@ -258,8 +258,7 @@ func TestAgent_Stats_Magic(t *testing.T) {
		s, ok := <-stats
		t.Logf("got stats with conn open: ok=%t, ConnectionCount=%d, SessionCountJetBrains=%d",
		ok, s.ConnectionCount, s.SessionCountJetbrains)
		return ok && s.ConnectionCount > 0 &&
		s.SessionCountJetbrains == 1
		return ok && s.SessionCountJetbrains == 1
		}, testutil.WaitLong, testutil.IntervalFast,
		"never saw stats with conn open",
		)
Expand Down