- Notifications
You must be signed in to change notification settings - Fork907
fix: add continue-on-error to SBOM generation and force flag to cosign clean#17288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
ThomasK33 merged 1 commit intomainfromthomask33/04-08-fix_add_continue-on-error_to_sbom_generation_and_force_flag_to_cosign_cleanApr 8, 2025
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
matifali approved these changesApr 8, 2025
Uh oh!
There was an error while loading.Please reload this page.
…n cleanChange-Id: Ide303c059b1a3d0e3fd77863310e99668325bc69Signed-off-by: Thomas Kosiewski <tk@coder.com>
7824a2f toa1c73a4Compareabe3ad6 intomain 33 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR makes the SBOM generation and attestation process more resilient by:
continue-on-error: trueto the SBOM generation steps in both CI and release workflows--force=trueflag to allcosign cleancommands to ensure they don't fail if in a non-interactive shell (which is the case for CI)Change-Id: Ide303c059b1a3d0e3fd77863310e99668325bc69
Signed-off-by: Thomas Kosiewskitk@coder.com