NotificationsYou must be signed in to change notification settings
Fork905
Star10k

feat: modify config-ssh to set the host suffix#17280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

spikecurtis merged 3 commits intomainfromspike/host-suffix/config-ssh-uses-host-suffix

Apr 8, 2025

Merged

feat: modify config-ssh to set the host suffix#17280

spikecurtis merged 3 commits intomainfromspike/host-suffix/config-ssh-uses-host-suffix

Apr 8, 2025

+52 −3

Conversation

Copy link

Contributor

spikecurtis commentedApr 7, 2025•
edited
Loading

Wires upconfig-ssh command to use a hostname suffix if configured.

part of:#16828

e.g.coder config-ssh --hostname-suffix spiketest gives:

# ------------START-CODER-----------# This section is managed by coder. DO NOT EDIT.## You should not hand-edit this section unless you are removing it, all# changes will be lost when running "coder config-ssh".## Last config-ssh options:# :hostname-suffix=spiketest#Host coder.* *.spiketest        ConnectTimeout=0        StrictHostKeyChecking=no        UserKnownHostsFile=/dev/null        LogLevel ERROR        ProxyCommand /home/coder/repos/coder/build/coder_config_ssh --global-config /home/coder/.config/coderv2 ssh --stdio --ssh-host-prefix coder. --hostname-suffix spiketest %h# ------------END-CODER------------

github-actionsbot assignedspikecurtis

Apr 7, 2025

Copy link

ContributorAuthor

spikecurtis commentedApr 7, 2025•
edited
Loading

This stack of pull requests is managed byGraphite. Learn more aboutstacking.

spikecurtis mentioned this pull request

Apr 7, 2025

feat: support --hostname-suffix flag on coder ssh#17279

Merged

spikecurtis marked this pull request as ready for review

April 7, 2025 13:18

spikecurtis requested review frombcpeinhardt,johnstcn andmafredri

April 7, 2025 13:19

mafredri approved these changes

Apr 7, 2025

View reviewed changes

Copy link

Member

mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Minor nit but otherwise LGTM 👍🏻

cli/configssh_test.goShow resolvedHide resolved

johnstcn reviewed

Apr 7, 2025

View reviewed changes

Copy link

Member

johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have one clarification regarding having both prefix and suffix enabled and expected behaviour / testing. Does it make sense to have both of these enabled?