- Notifications
You must be signed in to change notification settings - Fork913
feat: add CODER_WORKSPACE_HOSTNAME_SUFFIX#17268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -393,6 +393,7 @@ type DeploymentValues struct { | ||||||
TermsOfServiceURL serpent.String `json:"terms_of_service_url,omitempty" typescript:",notnull"` | ||||||
Notifications NotificationsConfig `json:"notifications,omitempty" typescript:",notnull"` | ||||||
AdditionalCSPPolicy serpent.StringArray `json:"additional_csp_policy,omitempty" typescript:",notnull"` | ||||||
WorkspaceHostnameSuffix serpent.String `json:"workspace_hostname_suffix,omitempty" typescript:",notnull"` | ||||||
Config serpent.YAMLConfigPath `json:"config,omitempty" typescript:",notnull"` | ||||||
WriteConfig serpent.Bool `json:"write_config,omitempty" typescript:",notnull"` | ||||||
@@ -944,7 +945,7 @@ func (c *DeploymentValues) Options() serpent.OptionSet { | ||||||
deploymentGroupClient = serpent.Group{ | ||||||
Name: "Client", | ||||||
Description: "These options change the behavior of how clients interact with the Coder. " + | ||||||
"Clients include theCoder CLI, Coder Desktop, IDE extensions, and the web UI.", | ||||||
YAML: "client", | ||||||
} | ||||||
deploymentGroupConfig = serpent.Group{ | ||||||
@@ -2549,6 +2550,17 @@ func (c *DeploymentValues) Options() serpent.OptionSet { | ||||||
Hidden: false, | ||||||
Default: "coder.", | ||||||
}, | ||||||
{ | ||||||
Name: "Workspace Hostname Suffix", | ||||||
Description: "Workspace hostnames use this suffix in SSH config and Coder Connect on Coder Desktop. By default it is coder, resulting in names like myworkspace.coder.", | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Suggested change
Suggestion: To differentiate the value from the text. | ||||||
Flag: "workspace-hostname-suffix", | ||||||
Env: "CODER_WORKSPACE_HOSTNAME_SUFFIX", | ||||||
YAML: "workspaceHostnameSuffix", | ||||||
Group: &deploymentGroupClient, | ||||||
Value: &c.WorkspaceHostnameSuffix, | ||||||
Hidden: false, | ||||||
Default: "coder", | ||||||
}, | ||||||
{ | ||||||
Name: "SSH Config Options", | ||||||
Description: "These SSH config options will override the default SSH config options. " + | ||||||
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Some generated files are not rendered by default. Learn more abouthow customized files appear on GitHub.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.