- Notifications
You must be signed in to change notification settings - Fork907
feat: add CODER_WORKSPACE_HOSTNAME_SUFFIX#17268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
spikecurtis commentedApr 7, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
This stack of pull requests is managed byGraphite. Learn more aboutstacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Nice, LGTM!
Just checking, we're not deprecating prefix yet?
| @@ -2549,6 +2550,17 @@ func (c *DeploymentValues) Options() serpent.OptionSet { | |||
| Hidden: false, | |||
| Default: "coder.", | |||
| }, | |||
| { | |||
| Name: "Workspace Hostname Suffix", | |||
| Description: "Workspace hostnames use this suffix in SSH config and Coder Connect on Coder Desktop. By default it is coder, resulting in names like myworkspace.coder.", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Description:"Workspace hostnames use this suffix in SSH config and Coder Connect on Coder Desktop. By default it is coder, resulting in names like myworkspace.coder.", | |
| Description:"Workspace hostnames use this suffix in SSH config and Coder Connect on Coder Desktop. By default it is\"coder\", resulting in names like myworkspace.coder.", |
Suggestion: To differentiate the value from the text.
87d9ff0 intomainUh oh!
There was an error while loading.Please reload this page.
No, not for a while. I'm marking some internal fields deprecated, but the external behavior isn't deprecated yet. |
Uh oh!
There was an error while loading.Please reload this page.
Adds deployment option
CODER_WORKSPACE_HOSTNAME_SUFFIX. This will eventually replaceCODER_SSH_HOSTNAME_PREFIX, but we will do this slowly and support both forcoder sshfor some time.Note that the name is changed to "workspace" hostname, since this suffix will also be used for Coder Connect on Coder Desktop, which is not limited to SSH.