- Notifications
You must be signed in to change notification settings - Fork1.1k
feat: implement reconciliation loop#17261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
158 commits Select commitHold shift + click to select a range
300e80f add prebuilds system user database changes and associated changes
SasSwartb788237 optionally prevent system users from counting to user count
dannykopping8122595 appease the linter
dannykoppingbfb7c28 add unit test for system user behaviour
dannykopping6639167 reverting RBAC changes; not relevant here
dannykopping769ae1d removing unnecessary changes
dannykoppinge7e9c27 exclude system user db tests from non-linux OSs
dannykopping3936047 Rename prebuild system user reference
SasSwart8bdcafb ensure that users.IsSystem is not nullable
SasSwart412d198 feat: add migrations and queries to support prebuilds
SasSwart51773ec Simplify workspace_latest_build view
dannykopping23773c2 Revert test change
dannykoppingbc3ff44 make gen
dannykopping7ff747e mark prebuilds as such and set their preset ids
SasSwartbaa3076 refactor: add comments to SQL queries
evgeniy-scherbinaed14fb3 test: added get-presets-backoff test
evgeniy-scherbina3cc74fb refactor: add comment to SQL query
evgeniy-scherbinafc32154 refactor: add comments + improve tests
evgeniy-scherbinad7b4ec4 fix: bug in SQL
evgeniy-scherbinae8b53f7 test: minor changes to the test
evgeniy-scherbina9df6554 refactor: remove job_status from SQL query
evgeniy-scherbinaccc309e refactor: embed preset_prebuilds table into presets table
evgeniy-scherbinaee1f16a refactor: rename sql table
evgeniy-scherbinad040ddd refactor: remove unnecessary JOIN
evgeniy-scherbina83a6722 refactor: remove unnecessary JOIN
evgeniy-scherbinacd70710 refactor: use INNER JOIN for consistency
evgeniy-scherbina97cc4ff refactor: simplify GetPresetsBackoff SQL Query
evgeniy-scherbina4d59039 Revert "refactor: simplify GetPresetsBackoff SQL Query"
evgeniy-scherbina205d6af refactor: improve GetPresetsBackoff query
evgeniy-scherbinae489e1b Merge remote-tracking branch 'origin/main' into prebuilds-db
evgeniy-scherbina1b29686 Merge remote-tracking branch 'origin/main' into prebuilds-db
evgeniy-scherbina20470e4 fix: bump migration numbers
evgeniy-scherbina7b9c8ce test: remove deprecated test
evgeniy-scherbinae189a0b fix: fix linter
evgeniy-scherbina692c0e5 fix: fix 000310_prebuilds.down migration
evgeniy-scherbinaf747db0 fix: fix fixture migration
evgeniy-scherbina3166a42 fix: fix get-presets-backoff test
evgeniy-scherbinaaa6b490 fix: fix linter
evgeniy-scherbinabc4e7d2 fix: fix linter
evgeniy-scherbinaf167b92 correctly select for the latest built with a preset in latest_prebuil…
SasSwart8fd34ab Merge remote-tracking branch 'origin/main' into prebuilds-db
SasSwart7a8ec49 Properly label and filter metrics for prebuilds
SasSwarta64d661 test: fix db tests
evgeniy-scherbinac787cd2 test: added tests for workspaces with multiple agents
evgeniy-scherbinabd38603 refactor: avoid code duplication
evgeniy-scherbina097f9c3 clarify query clause
SasSwart4cfdd6f tidy up dbauthz_test.go
SasSwart4a34d52 refactor: remove * usage from prebuilds.sql queries
evgeniy-scherbina8d9cd45 refactor: remove * usage from prebuilds views
evgeniy-scherbinaf870d7e refactor: join wlb with pj
evgeniy-scherbina18ad931 refactor: Rename SQL query
evgeniy-scherbina4667171 Added comments for SQL query
evgeniy-scherbinaa26c094 refactor: fix down migration
evgeniy-scherbina6ed4121 Merge remote-tracking branch 'origin/main' into prebuilds-db
SasSwart2312f41 renumber migrations
SasSwart8da7f47 Merge remote-tracking branch 'origin/prebuilds-db' into 16930
SasSwart5150a5c refactor: clarify comment for SQL query
evgeniy-scherbinabff34ea refactor: fix indentations
evgeniy-scherbinaef462b6 refactor: rename helper func in test package
evgeniy-scherbinadc45165 refactor: database level tests
evgeniy-scherbina9c8a352 refactor: database level tests
evgeniy-scherbinaeb80919 refactor: helper funcs in db-level tests
evgeniy-scherbina0b2bbee refactor: minor improvement in SQL query
evgeniy-scherbina3a97bf6 refactor: rename SQL queries
evgeniy-scherbina2eeb884 refactor: rename SQL queries
evgeniy-scherbina73f99e8 refactor: rename fields in SQL query
evgeniy-scherbinac942753 add tests to ensure workspace builds that include a preset have it se…
SasSwart9badf7c test to ensure we mark prebuilds as such
SasSwart6763ba2 make -B gen fmt
SasSwarte5117d7 add template_version_preset_id to mock types
SasSwartdfec884 Merge branch 'prebuilds-db' into 16930
SasSwart5065ad6 fix dbmem tests
SasSwarte354956 review notes. mostly rename isPrebuild to prebuild
SasSwart4d3aab6 Merge remote-tracking branch 'origin/main' into yevhenii/510-reconcil…
evgeniy-scherbina97b3886 fix dbmem tests
SasSwartfe60b56 feat: implement reconciliation loop
evgeniy-scherbinaeeb0407 refactor: temporary commit - tests are passing
evgeniy-scherbinae807d02 refactor: remove DeterminePrebuildsState lock
evgeniy-scherbinad78675e refactor: use TryAcquireLock
evgeniy-scherbina7f60a5d refactor: Verify ActionType in state_test.go
evgeniy-scherbina8f5c9f9 refactor: minor refactor
evgeniy-scherbina42582e1 refactor: minor refactoring
evgeniy-scherbina14d924c added comments
evgeniy-scherbina82e016c mark prebuilds as such and set their preset ids
SasSwartc03ea52 add tests to ensure workspace builds that include a preset have it se…
SasSwart3693d45 test to ensure we mark prebuilds as such
SasSwartbeb814f make -B gen fmt
SasSwarta5418ac add template_version_preset_id to mock types
SasSwartf4f9b17 fix dbmem tests
SasSwartd11fd58 go mod tidy && make -B gen
SasSwart31d3bf6 test: added few more tests
evgeniy-scherbina5007a83 refactor: remove redundant check for consistency
evgeniy-scherbinaa79fe4c refactor: use slice.Find instead of slice.Filter for backoff
evgeniy-scherbinac0246f4 refactor: make sure InProgress works on preset level as well
evgeniy-scherbinaed608cb refactor: remove irrelevant comment
evgeniy-scherbina70223e4 refactor: add BackoffUntil to validateActions func
evgeniy-scherbina07808c2 refactor: CR's fixes
evgeniy-scherbinaa2ceeb6 refactor: CR's fixes
evgeniy-scherbina73fb414 Remove todo
evgeniy-scherbina7e9c65f minor refactoring
evgeniy-scherbina2ca8030 refactor: remove deprecated TODOs
evgeniy-scherbinace83f92 refactor: slighly adjust comment
evgeniy-scherbina3bc4d8a refactor: CR fixes
evgeniy-scherbina2986574 Remove deprecated TODO
evgeniy-scherbinaaa22a8a refactor: update comments
evgeniy-scherbinaf41b19e refactor: remove deprecated TODO
evgeniy-scherbina61a88e4 deduplicate test and add back proto field
SasSwart9ac7a2c refactor: add RunLoop test
evgeniy-scherbinad0c2094 Merge remote-tracking branch 'origin/16930' into yevhenii/510-reconci…
evgeniy-scherbina474fc06 Fixes after merge
evgeniy-scherbina9fac5d7 refactor: simplify SQL query
evgeniy-scherbina868d0b6 refactor
evgeniy-scherbina5f204f2 minor fix
evgeniy-scherbina40b3e5f minor fix
evgeniy-scherbina5e3adbc make fmt
evgeniy-scherbina108720f make lint
evgeniy-scherbina9d8f6b1 chore: fix gpg forwarding test (#17355)
deansheatherb994eec refactor: fix linter
evgeniy-scherbinaeff754e refactor: fix linter
evgeniy-scherbina4b052be refactor: fix linter
evgeniy-scherbinabc5297c refactor: fix linter
evgeniy-scherbina0989636 refactor: fix linter
evgeniy-scherbina2b57ac4 refactor: fix linter
evgeniy-scherbina41d7e07 fix: linter
evgeniy-scherbinaab5fa8f fix: linter
evgeniy-scherbinaf485bc0 refactor: fix linter
evgeniy-scherbina074f768 refactor: fix linter
evgeniy-scherbinaa47627a refactor: fix imports
evgeniy-scherbinaeebb298 refactor: fix SQL comment
evgeniy-scherbina9a672dd refactor: rename dblock
evgeniy-scherbinac2f4561 Merge remote-tracking branch 'origin/main' into yevhenii/510-reconcil…
evgeniy-scherbina62fb3f4 refactor: add test when create-prebuild helper fails
evgeniy-scherbina742d0d3 refactor: add additional check for create-prebuilds flow
evgeniy-scherbinaf3e24b1 refactor: minor fixes in util.go
evgeniy-scherbina08aed24 refactor: minor fix in noop.go
evgeniy-scherbina951c8b5 refactor: add TestFilter in util/slice package
evgeniy-scherbina9c1e82f refactor: add doc comments
evgeniy-scherbina46e240c refactor: update comment
evgeniy-scherbina6dc1f68 fix: minor bug and add correspoding test
evgeniy-scherbina23964aa fix: minor fix for logging
evgeniy-scherbina0a4d053 fix: CR's fixes
evgeniy-scherbina98d203d fix: CR's fixes
evgeniy-scherbina145b9ff fix: CR's fixes
evgeniy-scherbina8b91668 CR's fixes
evgeniy-scherbinacccdab2 Update coderd/prebuilds/preset_snapshot_test.go
evgeniy-scherbinaa2e5643 Update coderd/prebuilds/preset_snapshot_test.go
evgeniy-scherbina1771c84 refactor: CR's fixes
evgeniy-scherbina1fc551d refactor: CR's fixes
evgeniy-scherbinad99c5cb refactor: CR's fixes
evgeniy-scherbinab98ccd4 fix: make sure prebuild is owned by prebuild user before deleting
evgeniy-scherbina936cc38 refactor: CR's fixes
evgeniy-scherbina32da1ab refactor: CR's fixes
evgeniy-scherbina5a403c0 Update enterprise/coderd/prebuilds/reconcile.go
evgeniy-scherbina908e6eb refactor: CR's fixes
evgeniy-scherbina77e4472 refactor: CR's fixes
evgeniy-scherbina853af80 refactor: CR's fixes
evgeniy-scherbina172177f Merge remote-tracking branch 'origin/main' into yevhenii/510-reconcil…
evgeniy-scherbinaa825bf0 refactor: reduce number of methods in Reconciler interface
evgeniy-scherbinaFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
CR's fixes
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit8b91668e354ab14ea4b84608b14443771c6b14bd
There are no files selected for viewing
80 changes: 40 additions & 40 deletionscoderd/prebuilds/preset_snapshot_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.