Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: fix permissions for workspace creation#17241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jaaydenh merged 7 commits intomainfromjaaydenh/workspace-creation-fix
Apr 3, 2025

Conversation

@jaaydenh
Copy link
Contributor

@jaaydenhjaaydenh commentedApr 3, 2025•
edited
Loading

This fixes the permissions check when creating a workspace by setting the owner_id to the current user's id. This was originally setting owner_id to *

createWorkspace: {object: {resource_type: "workspace",organization_id: organizationId,owner_id: userId,},action: "create",},

@jaaydenhjaaydenhforce-pushed thejaaydenh/workspace-creation-fix branch fromd226e87 to19fcd6fCompareApril 3, 2025 13:31
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What was the original issue?

@jaaydenhjaaydenhforce-pushed thejaaydenh/workspace-creation-fix branch from9bdd56a to49951a6CompareApril 3, 2025 14:11
Copy link
Member

@EmyrkEmyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I did not manually test, but this checks out with my reasoning

@jaaydenhjaaydenhforce-pushed thejaaydenh/workspace-creation-fix branch from50998fc to0b13269CompareApril 3, 2025 14:47
Copy link
Member

@johnstcnjohnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

:shipit:

@jaaydenhjaaydenhforce-pushed thejaaydenh/workspace-creation-fix branch from03a81d4 tod1f7eb0CompareApril 3, 2025 15:37
@jaaydenhjaaydenh merged commitccfe1bd intomainApr 3, 2025
29 checks passed
@jaaydenhjaaydenh deleted the jaaydenh/workspace-creation-fix branchApril 3, 2025 15:46
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsApr 3, 2025
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@johnstcnjohnstcnjohnstcn approved these changes

@EmyrkEmyrkEmyrk approved these changes

Assignees

@jaaydenhjaaydenh

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jaaydenh@johnstcn@Emyrk
[8]ページ先頭
©2009-2025 Movatter.jp