NotificationsYou must be signed in to change notification settings
Fork906
Star10k

fix: prevent invalid render output for build logs#17233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

Parkreiner merged 2 commits intomainfrommes/owws-tweaks

Apr 2, 2025

Merged

fix: prevent invalid render output for build logs#17233

Parkreiner merged 2 commits intomainfrommes/owws-tweaks

Apr 2, 2025

Conversation

Copy link

Member

Parkreiner commentedApr 2, 2025•
edited
Loading

No issue to link – fixing this because it was making it harder to diagnose some of the potential problems with our switch over to One-Way Web Sockets in the UI. There were too many extra errors being logged to the console

Changes made

UpdatedLine type inLogLine.tsx to support an ID value to prevent key conflicts during React rendering. Also deleted theLineWithID type, which became redundant after the change
Updated theLogs component to use the ID to avoid render key conflicts
Updated any component calls to add the ID as a prop

Notes

This does prevent a bunch of extraconsole.error calls that React will automatically spit out, so this should help us a good bit in the future
Beyond being a little annoying, there was a chance (that was tiny for now) that React could accidentally mix up component instances during re-renders (meaning logs could suddenly jump out of order in the UI). That wasn't my main goal with this PR (I just wanted less noisy logs), but that should now be impossible