- Notifications
You must be signed in to change notification settings - Fork906
refactor: update avatar sizes in groups, users and members#17230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
This PR refactors avatar sizes across several pages to use the "lg" size, ensuring consistency in avatar presentation.
- Updates avatar size props to "lg" in Users, Groups, and Members pages
- Refactors layout for group member avatars in GroupsPageView by replacing AvatarGroup with a custom layout
- Adjusts table and skeleton components for improved padding and sizing consistency
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| site/src/pages/UsersPage/UsersTable/UsersTableBody.tsx | Removed a flex container wrapping an avatar skeleton |
| site/src/pages/OrganizationSettingsPage/OrganizationMembersPageView.tsx | Updated avatar size and added conditional rendering for loading state |
| site/src/pages/GroupsPage/GroupsPageView.tsx | Replaced AvatarGroup with a custom flex layout including a Badge for extra members |
| site/src/pages/GroupsPage/GroupPage.tsx | Updated avatar size in the member row |
| site/src/components/Table/Table.tsx | Modified padding classes in table head and cells |
| site/src/components/LastSeen/LastSeen.tsx | Updated to include utility classes for whitespace handling |
| site/src/components/Avatar/AvatarDataSkeleton.tsx | Added a shrink-0 class to the skeleton for layout control |
| site/src/components/Avatar/AvatarData.tsx | Updated to default to avatar size "lg" and added a color class to the title span |
| site/src/components/Avatar/Avatar.tsx | Replaced explicit height/width classes with shorthand utility classes for avatar sizing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. I want to say that themembers check inGroupsPageView only shifted a level of indentation because of themembers check, but let me know if I missed something else that was updated
510bc37 intomainUh oh!
There was an error while loading.Please reload this page.
We updated the template and workspace avatars to be "lg" so to keep it consistent we have to do the same for the other avatars too.