- Notifications
You must be signed in to change notification settings - Fork928
feat: Add resource type and restyle terminal link#1722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat: Add resource type and restyle terminal link#1722
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| className={className} | ||
| target="_blank" | ||
| > | ||
| <ComputerIcon /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The version of Material UI we are using does not have the Terminal icon 😢
| import React from "react" | ||
| import * as TypesGen from "../../api/typesGenerated" | ||
| export const Language = { | ||
| linkText: "Openinterminal", | ||
| linkText: "Open terminal", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@kylecarbs which makes more sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I removed this to save some space 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm impartial! I think it's fair to remove thein to save space, but up to you!
Thanks for doing this! It looks great in context, but the story for just the terminal link has an alignment problem, maybe it needs a container or something. |
Closes#1721